-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/13268 introduce date range picker screen in Activity Log #13324
Issue/13268 introduce date range picker screen in Activity Log #13324
Conversation
…troduce-date-range-picker-screen
…troduce-date-range-picker-screen
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff, now we have a material picker that we can play with! 🌟
PS: I didn't use emoji this time, but I did use a suffix on each of my comments to give you some context of what to expect (like Minor: Xyx
or Idea: Xyz
). Let me know your thoughts.
WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/ActivityLogListFragment.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/viewmodel/activitylog/ActivityLogViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/viewmodel/activitylog/ActivityLogViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/ActivityLogListFragment.kt
Show resolved
Hide resolved
Thanks for the review @ParaskP7!
I like it. We actually already use "NitPick:" prefix on minor comments - eg. this comment. |
Material date range picker looks great! Good job 👍. Steps to reproduce:
|
…creen # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/ActivityLogListFragment.kt # WordPress/src/main/java/org/wordpress/android/viewmodel/activitylog/ActivityLogViewModel.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍. I've tested and confirm that last selected data range is saved properly after save action is performed after orientation change.
Partially fixes #13268
Merge instructions:
This PR introduces Material Fullscreen Date Range picker component in Activity Log. It overrides some styles of the material component to facilitate future styling. The design of the date range picker hasn't been finalised yet so ignore the overall styling for now.
Unit tests will be added in a separate PR.
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.