Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce activity log filters feature flag #13270

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Oct 30, 2020

Related to #13268

This PR introduces a local feature flag for the Activity Log filters feature. When the feature flag is enabled a "Date range" chips is shown in the activity log.

Note: It doesn't matter if it gets merged into 16.1 or 16.2.

To test:

  1. Open Activity Log and make sure the "Date range" chip is hidden
  2. My Site -> Avatar icon in the toolbar -> App Settings -> Test feature configuration
  3. Enable ActivityLogFiltersFeatureConfig and click on "Restart app"
  4. Go back to Activity Log and notice "Date range" chip is shown

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 30, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 30, 2020

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Tested the changes, I was able to see "Date range" chip after enabling ActivityLogFiltersFeatureConfig.

@ashiagr ashiagr merged commit 1797c18 into develop Nov 10, 2020
@ashiagr ashiagr deleted the issue/13268-introduce-feature-flag branch November 10, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants