Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg - Starter Page Templates Tooltip #11807

Merged
merged 18 commits into from
May 26, 2020
Merged

Gutenberg - Starter Page Templates Tooltip #11807

merged 18 commits into from
May 26, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented May 4, 2020 •
edited
Loading

Fixes wordpress-mobile/gutenberg-mobile#2169

Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2216
Gutenberg PR -> WordPress/gutenberg#21974
WordPress iOS PR -> wordpress-mobile/WordPress-iOS#14045

To test:

  • Download and install the build.
  • Open the app and go to Pages.
  • Tap on the add a new page button.
  • Expect to see the templates picker with the tooltip on top.
  • Scroll through the template options.
  • Expect the tooltip to stay visible.
  • Tap on the title of the page.
  • Expect to see the tooltip fade out.
  • Close the app.
  • Open the app and go to Pages.
  • Tap on the add a new page button.
  • Expect to see the templates picker without the tooltip.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 4, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@geriux geriux changed the title Gutenberg Mobile - Add async-storage package for Tooltip component Gutenberg - Add async-storage package for Tooltip component May 4, 2020
This was referenced May 5, 2020
Merged
Merged
Merged
@mkevins mkevins closed this May 6, 2020
@geriux geriux reopened this May 6, 2020
@geriux geriux changed the base branch from gutenberg/after_1.27.0 to develop May 6, 2020 08:44
@geriux geriux modified the milestone: 14.9 May 6, 2020
@geriux geriux changed the title Gutenberg - Add async-storage package for Tooltip component Gutenberg - Starter Page Templates Tooltip May 12, 2020
@geriux geriux marked this pull request as ready for review May 13, 2020 07:56
@geriux geriux requested a review from mkevins May 13, 2020 07:56
Gerardo Pacheco added 2 commits May 19, 2020 09:18
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 19, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

Gerardo Pacheco added 5 commits May 19, 2020 09:52
RN Tooltip component flag - shorter name
c92283b
Gutenberg - Tooltip component flag name change
a23cf2c
Merge branch 'develop' into gutenberg/tooltip-component
67fb26e 
# Conflicts:
#	WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
#	libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/EditorFragmentAbstract.java
#	libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergContainerFragment.java
#	libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergEditorFragment.java
Fix after merge
e7dceba
Fix after merge
17df204
mkevins
mkevins approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via steps here: WordPress/gutenberg#21974 (review) everything is working as described. LGTM!

@geriux geriux added this to the 15.0 milestone May 26, 2020
@geriux geriux merged commit ee93098 into develop May 26, 2020
@geriux geriux deleted the gutenberg/tooltip-component branch May 26, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

Add a Tooltip for template selection buttons
2 participants
@geriux @mkevins