Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] - Tooltip for template selection buttons #21974

Merged
merged 20 commits into from
May 26, 2020
Merged

[RNMobile] - Tooltip for template selection buttons #21974

merged 20 commits into from
May 26, 2020

Conversation

geriux
Copy link
Member

@geriux geriux commented Apr 29, 2020 •
edited
Loading

Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2216
WordPress iOS PR -> wordpress-mobile/WordPress-iOS#14045
WordPress Android PR -> wordpress-mobile/WordPress-Android#11807

Description

This PR closes wordpress-mobile/gutenberg-mobile#2169

Adds a Tooltip to point to the template selection buttons. The component itself has a simple logic and it is attached to the Picker component. If we need another tooltip within the editor we could use this as a base and make it reusable.

How has this been tested?

Steps to test
  • Open the main apps PR (iOS/Android).
  • Download and install the build.
  • Open the app and go to Pages.
  • Tap on the add a new page button.
  • Expect to see the templates picker with the tooltip on top.
  • Scroll through the template options.
  • Expect the tooltip to stay visible.
  • Tap on the title of the page.
  • Expect to see the tooltip fade out.
  • Close the app.
  • Open the app and go to Pages.
  • Tap on the add a new page button.
  • Expect to see the templates picker without the tooltip.

Screenshots

UX Interaction
iOS Android
iOS Screenshots
Tooltip Tooltip Dark mode
Android Screenshots
Tooltip Tooltip Dark mode

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@geriux geriux added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Apr 29, 2020
@github-actions
Copy link

github-actions bot commented Apr 29, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 1.12 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.48 kB 0 B
build/block-directory/style-rtl.css 788 B 0 B
build/block-directory/style.css 788 B 0 B
build/block-editor/index.js 105 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 7.17 kB 0 B
build/block-library/editor.css 7.17 kB 0 B
build/block-library/index.js 119 kB 0 B
build/block-library/style-rtl.css 7.48 kB 0 B
build/block-library/style.css 7.48 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 190 kB 0 B
build/components/style-rtl.css 17.1 kB 0 B
build/components/style.css 17.1 kB 0 B
build/compose/index.js 9.28 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.42 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.11 kB 0 B
build/edit-navigation/index.js 6.63 kB 0 B
build/edit-navigation/style-rtl.css 857 B 0 B
build/edit-navigation/style.css 856 B 0 B
build/edit-post/index.js 302 kB 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/index.js 13.8 kB 0 B
build/edit-site/style-rtl.css 5.53 kB 0 B
build/edit-site/style.css 5.53 kB 0 B
build/edit-widgets/index.js 7.87 kB 0 B
build/edit-widgets/style-rtl.css 4.58 kB 0 B
build/edit-widgets/style.css 4.57 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.6 kB 0 B
build/editor/style-rtl.css 5.06 kB 0 B
build/editor/style.css 5.06 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@geriux geriux changed the title [WIP][RNMobile] - Layout Picker - Tooltip [RNMobile] - Layout Picker - Tooltip May 5, 2020
@geriux geriux changed the title [RNMobile] - Layout Picker - Tooltip [RNMobile] - Tooltip for template selection buttons May 5, 2020
This was referenced May 5, 2020
Merged
Merged
Merged
@geriux geriux removed the [Status] In Progress Tracking issues with work in progress label May 5, 2020
@geriux geriux marked this pull request as ready for review May 13, 2020 07:56
@geriux geriux requested review from chipsnyder and mkevins May 13, 2020 07:56
@mkevins mkevins self-requested a review May 26, 2020 06:43
mkevins
mkevins approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via steps provided and everything works as expected. LGTM! 👍

@geriux geriux merged commit a9ac328 into master May 26, 2020
@geriux geriux deleted the rnmobile/tooltip-component branch May 26, 2020 07:28
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone May 26, 2020
@mchowning mchowning mentioned this pull request May 26, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@chipsnyder chipsnyder Awaiting requested review from chipsnyder

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 8.3
Development

Successfully merging this pull request may close these issues.

Add a Tooltip for template selection buttons
3 participants
@geriux @chipsnyder @mkevins