Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move photon url logic from VH to VM #10267

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Move photon url logic from VH to VM #10267

merged 2 commits into from
Jul 22, 2019

Conversation

malinajirka
Copy link
Contributor

Fixes #9639

This PR shouldn't change the behavior. It just moves getResizedImageUrl from ViewHolder into ViewModel.

  • removes unnecessary postViewHolderConfig
  • removes unnecessary reference to siteModel from PostListFragment
  • introduces injectable wrapper around ReaderUtils

To test:
Make sure featured images on post list items are being loaded

Update release notes:

  • No user facing changes

@malinajirka malinajirka added this to the 13.0 milestone Jul 22, 2019
@malinajirka malinajirka requested review from 0nko, nbradbury and mzorz July 22, 2019 12:18
@mzorz mzorz self-assigned this Jul 22, 2019
mzorz
mzorz approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested, works as expected. Code changes look good 👍 :shipit:

@mzorz mzorz merged commit 8b3f6a2 into develop Jul 22, 2019
@mzorz mzorz deleted the issue/9639-refactoring branch July 22, 2019 15:03
@mzorz mzorz mentioned this pull request Jul 22, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpmobilebot wpmobilebot wpmobilebot left review comments

@mzorz mzorz mzorz approved these changes

@0nko 0nko Awaiting requested review from 0nko

@nbradbury nbradbury Awaiting requested review from nbradbury

Assignees

@mzorz mzorz

Labels
None yet
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

Move feature image logic from PostListItemViewHolder to ViewModel
3 participants
@malinajirka @mzorz @wpmobilebot