Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move feature image logic from PostListItemViewHolder to ViewModel #9639

Closed
malinajirka opened this issue Apr 16, 2019 · 0 comments · Fixed by #10267
Closed

Move feature image logic from PostListItemViewHolder to ViewModel #9639

malinajirka opened this issue Apr 16, 2019 · 0 comments · Fixed by #10267
Assignees
@malinajirka
Labels
Tech Debt [Type] Task

Comments

@malinajirka
Copy link
Contributor

PostListItemViewHolder.showFeaturedImage(...) contains logic which should be moved to PostListItemUiStateHelper.

Also remove SiteModel from the PostListFragment as it won't be necessary after we remove SiteUtils.isPhotonCapable(site).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malinajirka malinajirka

Labels
Tech Debt [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move photon url logic from VH to VM wordpress-mobile/WordPress-Android
2 participants
@designsimply @malinajirka