Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local draft with more than one media fails to upload #9804

Closed
shiki opened this issue May 6, 2019 · 2 comments · Fixed by #9859
Closed

Local draft with more than one media fails to upload #9804

shiki opened this issue May 6, 2019 · 2 comments · Fixed by #9859
Assignees
@maxme
Labels
[Pri] High [Type] Bug

Comments

@shiki
Copy link
Member

shiki commented May 6, 2019

Expected behavior

A local draft with more than 2 media should be uploaded if there is an internet connection.

Actual behavior

The upload fails even after retrying multiple times.

Steps to reproduce the behavior

  1. Go offline
  2. Create a draft post
  3. Add 2 images to the post
  4. Exit the editor
  5. Go online
  6. Tap on the Retry button.

If there is only one media attached to the draft post, the upload succeeds.

Tested on Pixel 3, Android 9, WPAndroid develop (2e3b2a6)
@shiki shiki self-assigned this May 6, 2019
@diegoreymendez diegoreymendez mentioned this issue May 6, 2019
Closed
@shiki shiki mentioned this issue May 7, 2019
Closed
@malinajirka
Copy link
Contributor

Possibly related to #9802

@shiki shiki mentioned this issue May 8, 2019
Closed
@shiki
Copy link
Member Author

shiki commented May 13, 2019

Did not get much progress on this. There's a lot about the UploadService, PostUploadHandler, and MediaUploadHandler classes that I found difficult to understand. The next time I look at this, I'll probably start by documenting how these classes work.

@shiki shiki assigned maxme and unassigned shiki May 14, 2019
maxme added a commit that referenced this issue May 14, 2019
@maxme
Fix #9804: Make sure we call registerPostModel even if it's already r…
87b949b 
…egistered.

This is required to add new media to the Post associated media ids set.
@maxme maxme mentioned this issue May 14, 2019
Merged
shiki added a commit that referenced this issue May 14, 2019
@shiki
Merge pull request #9859 from wordpress-mobile/issue/9804-fix-local-d…
4fe6a85 
…raft-more-than-one-media-fials

Fix #9804: Make sure we call registerPostModel even if it's already registered
@yaelirub yaelirub added 5 and removed 5 labels Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxme maxme

Labels
[Pri] High [Type] Bug
Projects
None yet
Milestone
No milestone
4 participants
@maxme @shiki @yaelirub @malinajirka