Media Uploading notification doesn't seem to be in synch with the media uploading/uploaded

[daniloercoli]

Affected device(s)

Samsung S9 on Android 9.
Can't reproduce the issue on my other testing device (Nexus 5X on Android 7.1). Also tried on emulators with no luck.
@malinajirka confirmed that he was not able to reproduce this exact issue on his devices (Emulator + Pixel 3 Android 9).

Expected behavior

The Uploading notification to be correctly cleared if I stop the Media Uploading by tapping on the media and selecting "Stop Uploading".

Actual behavior

The network connection is correctly stopped, but the notification is still there in the notifications center, the progress indicator is of course stuck at the current position, and a new Upload failed notification is added to the stack.

Steps to reproduce the behavior

• Start Aztec
• Add a Video
• Tap on the video and select Stop Uploading
• See the notification still in the system NC, and the new notif about upload failed

See also Scenario 3 here.

I also noticed that sometimes weird things happen with media notifications.

• 2 uploading notifications not grouped into 1
  

• Tried to upload 2 files, after the 1st video finished I got this in the notifications center:
  
  (Not sure of the steps to replicate this issue)

Tested on current develop - d3c89dd7d4dcd3d138bc544642b3ace38cb2a96a

cc @mzorz
@marecar3

[daniloercoli]

I've investigated this a bit further with images, and I see uploading notifications reporting wrong info when adding images to the editor and there are errors uploading them.
EX:

• Start a new post

• Add 4 pictures to the editor

• 2 of those media fail uploading right immediately, and there is the red overlay over them

• The notifications center reports this info:
  

• When the 2 "good" pictures finishing to upload:
  

And then the app is stuck in the current state with notifications.

Note
In another test of mine I tapped retry in the editor and ended up in the following notification:

[daniloercoli]

Scenario no. 3

• Start a new post
• Add media to it
• Save it as draft and exit the app
• The media started uploading correctly
• If the media fails uploading for some reason, the notification is NOT refreshed

https://cloudup.com/ccVRBOLfH28

• Opening the app in posts list it says "Uploading media..." for the post (see the linked pictures above)

[designsimply]

I tried testing this a few times using WPAndroid alpha-170 on Pixel 3 Android 9 but I was unable to see any notifications in the system NC (41s). I tried checking notifications settings for the app itself and all looked well (screenshot).

[designsimply]

I was able to see this happen today while testing with WPAndroid alpha-171 on Pixel 3 Android 9 with these steps:

1. Create a new post and start uploading an image.
2. Turn off both cellular data and WiFi (separate from airplane mode).
3. Notice the image begins uploading again.
4. Notice the system notification saying "Uploading…" gets stuck open even after the image has successfully uploaded after network connectivity was returned.

^{Note: this notice seems like it should go away but it has been stuck there for quite a while *after* coming back from going offline in the middle of an image upload.}

@malinajirka would you mind giving this one another go to see if you are still unable to replicate the problem in testing?

[malinajirka]

I think this PR might solve the issue. I have been testing it on my Pixel 3 a few days ago and I never ended up with a stuck notification.

[malinajirka]

@designsimply I'd suggest closing this issue until someone encounters it again. I tried to reproduce it today without success. I still hope it got fixed in #9956.

[designsimply]

👍closing per the recommendation (and the hope it was fixed in #9956 🙂) with an ask to re-open if it comes up again.