Allow using the default font for the PreFormatter/HeaderFormatter #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
changed the title
geriux
force-pushed
the
feature/custom-header-font-size
branch
from
14b823c to
36d5f26
Compare
geriux
changed the title
This was referenced Dec 30, 2021
Closed
antonis
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Thank you for wrangling this @geriux 👍
I tested the generated build and the app behaves as expected. The code changes look consistent to me too 🎉
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's not an option to use a custom font size for the HeaderFormatter since it uses the default values for each level, as well as for the PreFormatter which uses the default monospace font.
This introduces a new configuration flag
useDefaultFontthat will allow to use thedefaultFontfor both formatters.To test use this WordPress build.