Mobile - RichText/AztecView - Enable customizing the font size for the Heading and Preformatted block. #37663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2021 12:51
- Update the font size if the tag changes, e.g changing the level of a Heading block. - Send a new flag to AztecView: blockUseDefaultFont, to enable using the defaultFont for the Heading and Preformatted block to be able to customize the font size for block-based themes.
geriux
added
the
Mobile App - i.e. Android or iOS
geriux
changed the title
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
added 2 commits
December 30, 2021 14:21
…w attribute tag within the text object in RichText.
geriux
commented
Jan 3, 2022
packages/react-native-editor/ios/GutenbergDemo.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
packages/react-native-editor/ios/GutenbergDemo.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
packages/react-native-editor/ios/GutenbergDemo.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
packages/react-native-editor/ios/GutenbergDemo.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
antonis
reviewed
Jan 4, 2022
packages/react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
Outdated
Show resolved
Hide resolved
antonis
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Great work @geriux 👍
I tested the the fix using the generated app and everything works as expected. The code changes also LGTM 🎉
I only left a minor suggestion.
geriux
force-pushed
the
rnmobile/feature/custom-heading-font-size
branch
from
94b36c2 to
36f73ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#4112
This PR allows customizing the font size for the Heading and Preformatted block on iOS. It depends on some changes in Aztec iOS, that introduces a new configuration variable
useDefaultFont.blockUseDefaultFont(iOS only) that will enable the AztecuseDefaultFontconfiguration flag.tagwithin thetextprop attributes needed to set the monospace font for the Preformatted block. We need to pass this data with the content because it has to be enabled before setting the HTML content.NOTE: This feature is still under the
__DEV__flag, so it's only available in development until is ready to ship.How has this been tested?
Using the build on the WordPress iOS PR
Test case 1
Precondition: Using a standard theme, e.g. Blank canvas
Test case 2
Precondition: Using a block-based theme.
defaultTest case 3
Precondition: Using a block-based theme.
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).