Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] issue137: 리뷰 작성 페이지 생성 #184

Merged
merged 45 commits into from
Aug 3, 2022
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
a447fd4
feat: 리뷰 수정/삭제 토글 버튼 추가
airman5573 Jul 31, 2022
856c422
refactor: token handler 삭제
airman5573 Jul 31, 2022
4cc9c51
feat: ReviewComment 컴포넌트 추가
airman5573 Jul 31, 2022
27cccfc
feat: id에 명시적 type 부여
airman5573 Jul 31, 2022
a1fd214
feat: custom-types에 대한 절대 경로 개선
airman5573 Jul 31, 2022
d58a28c
refactor: ReviewComment에서 사용하는 기능을 hook으로 분리
airman5573 Jul 31, 2022
267b3f0
feat: 객체인지 확인하는 유틸 함수 추가
airman5573 Jul 31, 2022
1121f59
feat: review form 추가
airman5573 Jul 31, 2022
3112d3c
feat: review 관련 타입 추가
airman5573 Jul 31, 2022
66d891f
feat: review comment 컴포넌트 추가
airman5573 Jul 31, 2022
ee564b1
feat: review component에 수정/삭제 기능 추가
airman5573 Jul 31, 2022
3811218
feat: review page 추가
airman5573 Jul 31, 2022
53a033a
resolve merge conflict
airman5573 Aug 1, 2022
6dc12f5
refactor: css 정리
airman5573 Aug 1, 2022
8858e36
feat: LetterCount관련 훅 추가
airman5573 Aug 1, 2022
6d680de
refactor: 상수 사용
airman5573 Aug 1, 2022
4618417
fix: review 작성 api path 수정
airman5573 Aug 1, 2022
f7a4b76
feat: prettier 절대 경로 추가
airman5573 Aug 1, 2022
691a919
feat: 리뷰 수정 삭제 기능 추가
airman5573 Aug 1, 2022
fa6d6c3
style: avatar size 추가
airman5573 Aug 1, 2022
b3bbc22
style: button에 hover,active 스타일 추가
airman5573 Aug 1, 2022
fd3aa5e
feat: button type 추가
airman5573 Aug 1, 2022
f1bc7fd
feat: 자잘한 스타일 수정
airman5573 Aug 1, 2022
030121c
refactor: DotDotDot -> KebabMenu 이름 변경
airman5573 Aug 1, 2022
ff5144b
Merge branch 'develop' of https://github.com/woowacourse-teams/2022-m…
airman5573 Aug 1, 2022
1c10891
feat: 후기를 스터디 룸에 이동
airman5573 Aug 1, 2022
2441df2
feat: useForm에 reset함수 추가
airman5573 Aug 1, 2022
07eee3e
feat: 리뷰 작성후 field 리셋
airman5573 Aug 1, 2022
dc5a468
style: className대신 styled-component로 대체
airman5573 Aug 2, 2022
426cd8f
feat: 서버 api url 변경
airman5573 Aug 2, 2022
0292a2d
refactor: api response/request type 변경
airman5573 Aug 2, 2022
fe8ac9a
refactor: totalResults -> totalCount 변경
airman5573 Aug 2, 2022
1326f01
refactor: type -> import type
airman5573 Aug 2, 2022
11bc393
refactor: api관련 함수들을 export default로 변경
airman5573 Aug 2, 2022
053142d
refactor: @pages 우선순위 낮춤
airman5573 Aug 2, 2022
f444f80
refactor: import type으로 변경 및 prop을 props로 변경
airman5573 Aug 2, 2022
5cbbf6b
refactor: 한곳에서 import 하는 방식으로 변경
airman5573 Aug 2, 2022
c94c3c2
refactor: 한곳에서 import 하는 방식으로 변경
airman5573 Aug 2, 2022
8c8845c
refactor: MyStudyPage 개선
airman5573 Aug 2, 2022
6c3af6a
refactor: util 함수 분리
airman5573 Aug 2, 2022
41009ac
refactor: @utils prettier 위치 설정
airman5573 Aug 2, 2022
a2d2683
refactor: prettier 적용
airman5573 Aug 2, 2022
53e192c
refactor: page의 로직 부분을 custom hook으로 분리
airman5573 Aug 3, 2022
4eee55e
refactor: review가 없는 경우 로직 처리 수정
airman5573 Aug 3, 2022
7d64cb4
fix: msw tokenHandler 복구
airman5573 Aug 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: import type으로 변경 및 prop을 props로 변경
Co-authored-by: TaeYoon <[email protected]>
airman5573 and nan-noo committed Aug 2, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit f444f80fa50fa472f6ead5f91bb95d372fa87db7
5 changes: 3 additions & 2 deletions frontend/src/components/arrow-button/ArrowButton.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import SlideButton, { SlideButtonProps } from '@components/arrow-button/ArrowButton';
import SlideButton from '@components/arrow-button/ArrowButton';
import type { SlideButtonProps } from '@components/arrow-button/ArrowButton';

export default {
title: 'Components/SlideButton',
2 changes: 1 addition & 1 deletion frontend/src/components/avatar/Avatar.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import Avatar from '@components/avatar/Avatar';
import type { AvatarProps } from '@components/avatar/Avatar';
6 changes: 3 additions & 3 deletions frontend/src/components/button/Button.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import Button from '@components/button/Button';
import type { ButtonProp } from '@components/button/Button';
import type { ButtonProps } from '@components/button/Button';

export default {
title: 'Components/Button',
component: Button,
};

const Template: Story<ButtonProp> = props => <Button {...props} />;
const Template: Story<ButtonProps> = props => <Button {...props} />;

export const Default = Template.bind({});
Default.args = {
4 changes: 2 additions & 2 deletions frontend/src/components/button/Button.style.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Theme, css } from '@emotion/react';
import styled from '@emotion/styled';

import type { ButtonProp } from '@components/button/Button';
import type { ButtonProps } from '@components/button/Button';

const applyOutlineButtonStyle = ({ theme, isLoading }: { theme: Theme; isLoading?: boolean }) => css`
transition: 0.3s;
@@ -52,7 +52,7 @@ export const LoadingIndicator = styled.div`
}
`;

export const Button = styled.button<ButtonProp>`
export const Button = styled.button<ButtonProps>`
${({ theme, fluid, outline, isLoading }) => css`
width: ${fluid ? '100%' : 'auto'};
padding: 20px 10px;
6 changes: 3 additions & 3 deletions frontend/src/components/button/Button.tsx
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ import type { MakeOptional } from '@custom-types';

import * as S from '@components/button/Button.style';

export type ButtonProp = {
export type ButtonProps = {
className?: string;
children: string;
type?: 'submit' | 'button';
@@ -15,7 +15,7 @@ export type ButtonProp = {
onClick?: React.MouseEventHandler<HTMLButtonElement>;
};

type OptionalButtonProp = MakeOptional<ButtonProp, 'fluid' | 'onClick' | 'outline'>;
type OptionalButtonProps = MakeOptional<ButtonProps, 'fluid' | 'onClick' | 'outline'>;

const LoadingIndicator: React.FC = () => {
return (
@@ -27,7 +27,7 @@ const LoadingIndicator: React.FC = () => {
);
};

const Button: React.FC<OptionalButtonProp> = ({
const Button: React.FC<OptionalButtonProps> = ({
className,
children,
type = 'submit',
4 changes: 2 additions & 2 deletions frontend/src/components/card/Card.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import type { CardProps } from '@components/card/Card';
import Card from '@components/card/Card';
@@ -28,7 +28,7 @@ Default.args = {
'https://images.unsplash.com/photo-1456513080510-7bf3a84b82f8?ixlib=rb-1.2.1&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=1673&q=80',
thumbnailAlt: '이미지 Alt',
title: '타이틀',
description: '세부 설명',
excerpt: '한줄 설명',
extraChips: [
<Chip disabled={false} key="1">
Chip
2 changes: 1 addition & 1 deletion frontend/src/components/chip/Chip.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import type { ChipProps } from '@components/chip/Chip';
import Chip from '@components/chip/Chip';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import type { LetterCounterProps } from '@components/letter-counter/LetterCounter';
import LetterCounter from '@components/letter-counter/LetterCounter';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import MarkdownRender from '@components/markdown-render/MarkdownRender';
import Wrapper from '@components/wrapper/Wrapper';
Empty file.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { forwardRef, useState } from 'react';
import { forwardRef } from 'react';

import * as S from '@components/positive-number-input/PositiveNumberInput.style';

17 changes: 17 additions & 0 deletions frontend/src/components/study-chip/StudyChip.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import type { Story } from '@storybook/react';

import type { StudyChipProps } from '@components/study-chip/StudyChip';
import StudyChip from '@components/study-chip/StudyChip';

export default {
title: 'Components/StudyChip',
component: StudyChip,
argTypes: {
isOpen: { controls: 'boolean' },
},
};

const Template: Story<StudyChipProps> = props => <StudyChip {...props} />;

export const Default = Template.bind({});
Default.args = {};
Empty file.
2 changes: 1 addition & 1 deletion frontend/src/components/study-chip/StudyChip.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Chip from '@components/chip/Chip';

type StudyChipProps = {
export type StudyChipProps = {
isOpen: boolean;
};

2 changes: 1 addition & 1 deletion frontend/src/components/tag-chip/TagChip.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import TagChip from '@components/tag-chip/TagChip';
import type { TagChipProps } from '@components/tag-chip/TagChip';
1 change: 1 addition & 0 deletions frontend/src/custom-types/common.d.ts
Original file line number Diff line number Diff line change
@@ -7,5 +7,6 @@ declare namespace NodeJS {
export type ProcessEnv = {
API_URL: string;
CLIENT_ID: string;
NODE_ENV: 'development' | 'production';
};
}
5 changes: 3 additions & 2 deletions frontend/src/layout/footer/Footer.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import Footer from '@layout/footer/Footer';
import type { FooterProps } from '@layout/footer/Footer';

export default {
title: 'Components/Footer',
component: Footer,
};

const Template: Story = () => <Footer />;
const Template: Story<FooterProps> = props => <Footer {...props} />;

export const Default = Template.bind({});
Default.args = {};
2 changes: 1 addition & 1 deletion frontend/src/layout/header/Header.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import Header from '@layout/header/Header';
import type { HeaderProps } from '@layout/header/Header';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';
import { useState } from 'react';

import DropDownBox from '@layout/header/components/drop-down-box/DropDownBox';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import Logo from '@layout/header/components/logo/Logo';

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import NavButton from '@layout/header/components/nav-button/NavButton';
import type { NavButtonProps } from '@layout/header/components/nav-button/NavButton';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story } from '@storybook/react';
import type { Story } from '@storybook/react';

import SearchBar from '@layout/header/components/search-bar/SearchBar';
import type { SearchBarProps } from '@layout/header/components/search-bar/SearchBar';
Loading