[FE] issue137: 리뷰 작성 페이지 생성 #184

airman5573 · 2022-08-01T13:35:48Z

요약

리뷰 작성 페이지를 생성했습니다
StudyRoom에 리뷰 작성 페이지(TabPanel)을 붙였습니다
리뷰 작성 / 수정 / 삭제 기능을 구현했습니다. 다만, Backend API가 아직 없는 관계로 정상 작동하지는 않습니다.

close #137

…oamoa into feat/137-review-page

nan-noo · 2022-08-02T04:39:56Z

frontend/src/api/getStudyDetail.ts

@@ -1,4 +1,4 @@
-import { StudyDetail } from '@custom-types/index';
+import { StudyDetail } from '@custom-types';


nan-noo · 2022-08-02T04:40:08Z

frontend/src/api/patchReview.ts

+export const patchReview = async ({ studyId, reviewId, content }: EditReviewQueryData) => {
+  const response = await axiosInstance.patch<EmptyObject, any, EditReviewQueryData>(


nan-noo · 2022-08-02T04:43:24Z

frontend/src/api/postReview.ts

+import axiosInstance from '@api/axiosInstance';
+
+export const postReview = async ({ studyId, content }: ReviewQueryData) => {
+  const response = await axiosInstance.post<EmptyObject, any, { content: string }>(`/api/studies/${studyId}/reviews`, {


회의결과 any대신 AxiosResponse을 넣어주기로 했습니다

nan-noo · 2022-08-02T04:47:26Z

frontend/src/components/button/Button.tsx

@@ -1,17 +1,18 @@
 import { noop } from '@utils/index';


얘도 index 없애면 좋을 것 같아요!

nan-noo · 2022-08-02T04:48:01Z

frontend/src/components/kebab-menu/KebabMenu.style.tsx

+import { css } from '@emotion/react';
+import styled from '@emotion/styled';
+
+export const KebabMenu = styled.ul`


이름이 아주 적절하군요 :D

nan-noo · 2022-08-02T06:00:39Z

frontend/src/custom-types/index.ts

+export type StudyId = number;
+export type TagId = number;
+export type ReviewId = number;
+export type MemberId = number;
+export type CategoryId = number;


nan-noo · 2022-08-02T06:02:21Z

frontend/src/mocks/handlers.ts

@@ -89,6 +89,6 @@ export const handlers = [
  }),
  ...detailStudyHandlers,
  ...tagHandlers,
-  ...tokenHandlers,


이거 지우면 로그인 모킹서버가 안 돼요!

복구했습니다!

nan-noo · 2022-08-02T06:02:48Z

frontend/src/mocks/tokenHandlers.ts

-import { rest } from 'msw';
-
-export const tokenHandlers = [
-  rest.post('/api/login/token', (req, res, ctx) => {
-    const code = req.url.searchParams.get('code');
-
-    if (!code) {
-      return res(ctx.status(400), ctx.json({ message: '잘못된 요청입니다.' }));
-    }
-    return res(ctx.status(200), ctx.json({ token: 'asddfasdfassdf' }));
-  }),
-];


복구해주세요!!

nan-noo · 2022-08-02T06:03:56Z

frontend/src/custom-types/index.ts

+export type DD = `0${oneToNine}` | `1${d}` | `2${d}` | `3${0 | 1}`;
+export type MM = `0${oneToNine}` | `1${0 | 1 | 2}`;
+export type YYYY = `20${d}${d}`;
+export type DateYMD = `${YYYY}-${MM}-${DD}`;


nan-noo · 2022-08-02T06:06:11Z

frontend/src/mocks/reviewHandler.ts

+        ctx.status(200),
+        ctx.json({
+          reviews: reviewJSON.reviews.slice(0, sizeNum),
+          totalResults: reviewJSON.reviews.length,


이거 totalResults -> totalCount로 바꿔주세요!

Co-authored-by: TaeYoon <[email protected]>

airman5573 added 28 commits July 31, 2022 15:24

feat: 리뷰 수정/삭제 토글 버튼 추가

a447fd4

refactor: token handler 삭제

856c422

feat: ReviewComment 컴포넌트 추가

4cc9c51

feat: id에 명시적 type 부여

27cccfc

feat: custom-types에 대한 절대 경로 개선

a1fd214

refactor: ReviewComment에서 사용하는 기능을 hook으로 분리

d58a28c

feat: 객체인지 확인하는 유틸 함수 추가

267b3f0

feat: review form 추가

1121f59

feat: review 관련 타입 추가

3112d3c

feat: review comment 컴포넌트 추가

66d891f

feat: review component에 수정/삭제 기능 추가

ee564b1

feat: review page 추가

3811218

resolve merge conflict

53a033a

refactor: css 정리

6dc12f5

feat: LetterCount관련 훅 추가

8858e36

refactor: 상수 사용

6d680de

fix: review 작성 api path 수정

4618417

feat: prettier 절대 경로 추가

f7a4b76

feat: 리뷰 수정 삭제 기능 추가

691a919

style: avatar size 추가

fa6d6c3

style: button에 hover,active 스타일 추가

b3bbc22

feat: button type 추가

fd3aa5e

feat: 자잘한 스타일 수정

f1bc7fd

refactor: DotDotDot -> KebabMenu 이름 변경

030121c

Merge branch 'develop' of https://github.com/woowacourse-teams/2022-m…

ff5144b

…oamoa into feat/137-review-page

feat: 후기를 스터디 룸에 이동

1c10891

feat: useForm에 reset함수 추가

2441df2

feat: 리뷰 작성후 field 리셋

07eee3e

airman5573 added 🚀 feature New feature or request 😁 frontend New frontend feature labels Aug 1, 2022

airman5573 requested a review from nan-noo August 1, 2022 13:35

airman5573 self-assigned this Aug 1, 2022

airman5573 added 2 commits August 2, 2022 14:20

style: className대신 styled-component로 대체

dc5a468

feat: 서버 api url 변경

426cd8f

nan-noo requested changes Aug 2, 2022

View reviewed changes

airman5573 and others added 15 commits August 2, 2022 17:18

refactor: api response/request type 변경

0292a2d

Co-authored-by: TaeYoon <[email protected]>

refactor: totalResults -> totalCount 변경

fe8ac9a

Co-authored-by: TaeYoon <[email protected]>

refactor: type -> import type

1326f01

Co-authored-by: TaeYoon <[email protected]>

refactor: api관련 함수들을 export default로 변경

11bc393

Co-authored-by: TaeYoon <[email protected]>

refactor: @pages 우선순위 낮춤

053142d

Co-authored-by: TaeYoon <[email protected]>

refactor: import type으로 변경 및 prop을 props로 변경

f444f80

Co-authored-by: TaeYoon <[email protected]>

refactor: 한곳에서 import 하는 방식으로 변경

5cbbf6b

Co-authored-by: TaeYoon <[email protected]>

refactor: 한곳에서 import 하는 방식으로 변경

c94c3c2

Co-authored-by: TaeYoon <[email protected]>

refactor: MyStudyPage 개선

8c8845c

Co-authored-by: TaeYoon <[email protected]>

refactor: util 함수 분리

6c3af6a

Co-authored-by: TaeYoon <[email protected]>

refactor: @utils prettier 위치 설정

41009ac

Co-authored-by: TaeYoon <[email protected]>

refactor: prettier 적용

a2d2683

Co-authored-by: TaeYoon <[email protected]>

refactor: page의 로직 부분을 custom hook으로 분리

53e192c

Co-authored-by: TaeYoon <[email protected]>

refactor: review가 없는 경우 로직 처리 수정

4eee55e

Co-authored-by: TaeYoon <[email protected]>

fix: msw tokenHandler 복구

7d64cb4

Co-authored-by: TaeYoon <[email protected]>

nan-noo approved these changes Aug 3, 2022

View reviewed changes

nan-noo merged commit fb309a0 into develop Aug 3, 2022

nan-noo deleted the feat/137-review-page branch August 3, 2022 06:11

This was linked to issues Aug 3, 2022

[FE] 마이 스터디 리스트 증폭 문제 #189

Closed

[FE] 스터디 후기 작성 구현 #137

Closed

[FE] 절대경로에 index가 붙는 불편함 (@utils/index) #154

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FE] issue137: 리뷰 작성 페이지 생성 #184

[FE] issue137: 리뷰 작성 페이지 생성 #184

airman5573 commented Aug 1, 2022

nan-noo Aug 2, 2022

nan-noo Aug 2, 2022

nan-noo Aug 2, 2022

nan-noo Aug 2, 2022

nan-noo Aug 2, 2022

nan-noo Aug 2, 2022

nan-noo Aug 2, 2022

airman5573 Aug 3, 2022

nan-noo Aug 2, 2022

airman5573 Aug 3, 2022

nan-noo Aug 2, 2022

nan-noo Aug 2, 2022

		@@ -1,4 +1,4 @@
		import { StudyDetail } from '@custom-types/index';
		import { StudyDetail } from '@custom-types';

		export const patchReview = async ({ studyId, reviewId, content }: EditReviewQueryData) => {
		const response = await axiosInstance.patch<EmptyObject, any, EditReviewQueryData>(

[FE] issue137: 리뷰 작성 페이지 생성 #184

[FE] issue137: 리뷰 작성 페이지 생성 #184

Conversation

airman5573 commented Aug 1, 2022

요약

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment