Add retry counter meta to order to avoid duplicate invoice error on c… #371
Conversation
| $this->session_handler->destroy_session_data(); | ||
| wc_add_notice( $error_message, 'error' ); | ||
|
|
||
| return $failure_data; | ||
| } | ||
|
|
||
| WC()->cart->empty_cart(); |
There was a problem hiding this comment.
I´ve moved it from OrderProcessor::process to here because otherwise there were no chance to retry the payment when the payment is not saved on PayPal.
There was a problem hiding this comment.
In order to prevent subscriptions renewals to fail because no payment stored for customer we are introducing a check after the payment to see if the payment is saved on PayPal or not, if it´s not saved then we set the WC order as failed.
The problem is that if the customer tries again with the same order it gets a DUPLICATE_INVOICE_ID, here is how I currently implemented it:
- POST order with Auth intent
- PATCH
- Authorize
- Check if payment is saved, if so capture auth order.
The above works, however if point 4 fails, we void the auth order and start again:
- POST order with Auth intent
- PATCH
- Authorize, here we get DUPLICATE_INVOICE_ID
The error is because as the PayPal authorization was successful, that order ID is “used”, so we have to increment or otherwise alter the invoice ID.
I´ve implemented the later by adding a counter at the end, so if WC-001 is used, we alter it to WC-001-1.
Fixes #367.