Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RC] When paying for a subscription and vaulting fails, cart is cleared (423) #367

Closed
jorgeatorres opened this issue Nov 16, 2021 · 0 comments · Fixed by #371
Closed

[RC] When paying for a subscription and vaulting fails, cart is cleared (423) #367

jorgeatorres opened this issue Nov 16, 2021 · 0 comments · Fixed by #371
Milestone

Comments

@jorgeatorres
Copy link
Member

Describe the bug

When trying to pay for a subscription with DCC using a credit card number that doesn't permit vaulting (for instance, any card from the CC generator), the order is not allowed to continue (which was fixed in #308) but for some reason the whole cart is cleared, which can result in a bunch of strange errors should the user attempt to re-submit the form.

To reproduce

  1. Setup DCC with vaulting enabled.
  2. Add a subscription product to the cart.
  3. Go to https://developer.paypal.com/developer/creditCardGenerator and generate some CC details.
  4. Go to Checkout and enter the previously generated card details.
  5. Click "Place Order".
  6. Confirm that placing order fails because the method wasn't stored in the vault correctly.
  7. Click "Place Order" again to see a weird error message.
  8. Refresh the page and see the cart has been emptied, preventing users from re-attempting payment.

Screenshots
Screencast:

screencast1

Expected behavior

Users should be allowed to use other CC details to complete payment. Card shouldn't be cleared.

@isabellainpsyde isabellainpsyde changed the title [RC] When paying for a subscrition and vaulting fails, cart is cleared [RC] When paying for a subscrition and vaulting fails, cart is cleared (423) Nov 17, 2021
@jorgeatorres jorgeatorres changed the title [RC] When paying for a subscrition and vaulting fails, cart is cleared (423) [RC] When paying for a subscription and vaulting fails, cart is cleared (423) Nov 17, 2021
@Dinamiko Dinamiko added this to the Next Version milestone Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants