This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix wc-settings not loading when a script that depend on it is in the header #5059
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
nielslange
and removed request for
a team
senadir
added
type: bug
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
senadir
added
the
needs: dev note
|
|
senadir
changed the title
mikejolley
reviewed
Nov 4, 2021
src/AssetsController.php
Outdated
| @@ -38,6 +38,8 @@ protected function init() { | |||
| add_action( 'body_class', array( $this, 'add_theme_body_class' ), 1 ); | |||
| add_action( 'admin_body_class', array( $this, 'add_theme_body_class' ), 1 ); | |||
| add_action( 'admin_enqueue_scripts', array( $this, 'update_block_style_dependencies' ), 20 ); | |||
| add_action( 'wp_enqueue_scripts', array( $this, 'update_block_settings_dependencies' ), 1 ); | |||
There was a problem hiding this comment.
I'm not sure, as this is your commit.
There was a problem hiding this comment.
I don't recall adding it, it shouldn't be needed. If anything, it should be a late priority.
mikejolley
reviewed
Nov 4, 2021
| wp_add_inline_script( | ||
| $error_handle, | ||
| sprintf( 'console.warn( "%s" );', $error_message ) | ||
| ); |
mikejolley
reviewed
Nov 4, 2021
There was a problem hiding this comment.
Question below. Everything else looks ok. Let @nielslange give final approval.
senadir
force-pushed
the
fix/wc-settings-not-loading
branch
from
63072c2
to
d60415a
Compare
nielslange
added
the
skip-changelog
|
@mikejolley this code seems to be running on all registered scripts, even the ones not enqueued on the current page. I'm seeing it on the checkout frontend for an editor script. I guess that's not something we can avoid?
|
|
@senadir could try using |
|
|
|
We can try |
|
Maybe it is queue. You can cross-reference the objects in |
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
… header (woocommerce#5059) * Enqueue in header if required. * revert scripts change * Dirty fix for settings dependency * Also implement in admin * add console warn * grammar issues * increase priority Co-authored-by: Mike Jolley <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
… header (woocommerce#5059) * Enqueue in header if required. * revert scripts change * Dirty fix for settings dependency * Also implement in admin * add console warn * grammar issues * increase priority Co-authored-by: Mike Jolley <[email protected]>
11 tasks
|
@senadir Could you give some hints on how to act upon that warning? What is the recommended way to register a block in the footer? See https://github.com/woocommerce/automatewoo/issues/1304 |
|
If you're loading scripts using the block.json then it will load up in the header sadly, you will need to enqueue your scripts manually. |
|
@senadir or @mikejolley is this (showing a warning for blocks registering scripts via There's a couple things we might want to consider:
|
|
I'd need to look at this again to refresh memory, but I think we currently just dump a variable on the page with the settings object right? What if that were a callback that added the settings after initial load? I guess this could break some blocks/utils relying on settings being there on load however. |
Merged
11 tasks
|
Seeing this come up here with a user, letting them know not to worry about it. 7761451-zd-a8c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cherry-picked from #5045
The goal of it is to fix an issue in which a script:
register_block_type( block.json )for example).wc-settingsor something that depend on it likewc-blocks-checkout,wc-price-format.would break the page because
wc-settingsinline script would not load.This PR (by @mikejolley) fixes the issue by forcing scripts that depend on
wc-settingsto print in the footer.Testing steps
npx wp-create-block test-blockand include something from@woocommerce/blocks-checkoutor@woocommerce/price-format.wc-settingsscript enqueued.Changelog