This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move checkbox control to checkout package #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
skip-changelog
|
Size Change: -1.42 kB (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
nerrad
reviewed
Nov 2, 2021
|
I will be breaking this PR up to 3 PRs since it does 3 distinct things along with a 4 PR I have. |
This was referenced Nov 3, 2021
mikejolley
force-pushed
the
move/checkbox-control-component
branch
from
82e04ca
to
ca21a99
Compare
|
@senadir rebased with the single change, ready for review. |
senadir
approved these changes
Nov 5, 2021
|
Merging after tests pass. |
senadir
force-pushed
the
move/checkbox-control-component
branch
from
ca21a99
to
7fdd674
Compare
mikejolley
force-pushed
the
move/checkbox-control-component
branch
from
7fdd674
to
c72921d
Compare
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Move checkbox control to checkout package * Revert import change in editor
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Move checkbox control to checkout package * Revert import change in editor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
CheckboxControlcomponent, which is only used in the cart/checkout blocks, to the Checkout package. This will allow extensions to consume it. We intend to use this in the Newsletter plugin integrations.This is part of #5044
Testing
This only requires a smoke test; successful build, and test a block can still use the component, for example, terms and conditions block in Checkout.