Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Option to 'use shipping address for billing': add attribute and make it work in the frontend #1857

Merged
merged 6 commits into from
Mar 4, 2020
Merged

Option to 'use shipping address for billing': add attribute and make it work in the frontend #1857

merged 6 commits into from
Mar 4, 2020

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Mar 3, 2020 •
edited
Loading

Fixes #1485.

Screenshots

Screenshot

How to test the changes in this Pull Request:

  1. Create a post or page with the Checkout block.
  2. Interact with the Billing address attribute toggle and verify the block updates accordingly (the input field default state should change and Billing Address step should appear/disappear).
  3. View the post in the frontend and verify you can introduce a billing address.

@Aljullu Aljullu added the focus: blocks Specific work involving or impacting how blocks behave. label Mar 3, 2020
@Aljullu Aljullu added this to the Future Release milestone Mar 3, 2020
@Aljullu Aljullu requested a review from a team as a code owner March 3, 2020 16:33
@Aljullu Aljullu self-assigned this Mar 3, 2020
@Aljullu Aljullu requested review from mikejolley and removed request for a team March 3, 2020 16:33
senadir
senadir reviewed Mar 4, 2020
View reviewed changes
assets/js/base/components/checkout/form-step/style.scss
@@ -1,6 +1,10 @@
$circle-size: 24px;
$line-offset-from-circle-size: 8px;

.wc-block-checkout-form {
counter-reset: checkout-step;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this!

mikejolley
mikejolley approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Merging this as I'm about to start adding some options to checkout too and don't want to conflict :)

@mikejolley mikejolley merged commit aeda282 into master Mar 4, 2020
@mikejolley mikejolley deleted the add/shipping-as-billing-attribute branch March 4, 2020 15:13
@haszari haszari mentioned this pull request Mar 4, 2020
Merged
@nerrad nerrad modified the milestones: Future Release, 2.6.0 Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@senadir senadir senadir left review comments

@mikejolley mikejolley mikejolley approved these changes

Assignees

@Aljullu Aljullu

Labels
focus: blocks Specific work involving or impacting how blocks behave.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Checkout Block: Shipping options for block
5 participants
@Aljullu @mikejolley @senadir @nerrad @woocommercebot