[Woo POS][Non-Simple Products] Remove variation quantity in Products and Variations screen #13225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnirudhBhat
added
type: task
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13225 +/- ##
=========================================
Coverage 40.64% 40.64%
Complexity 6380 6380
=========================================
Files 1349 1349
Lines 77400 77400
Branches 10647 10647
=========================================
Hits 31461 31461
Misses 43159 43159
Partials 2780 2780 ☔ View full report in Codecov by Sentry. |
samiuelson
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
👋 LGTM, @AnirudhBhat, but don't forget to remove unused resource.
|
|
||
| Text( | ||
| text = stringResource( | ||
| id = R.string.woopos_items_list_variable_product_variations, |
There was a problem hiding this comment.
The string resource is not used anymore
There was a problem hiding this comment.
Good catch. Removed here: 7fbd2ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13221
Description
This PR removes variation quantity in Products and Variations screen. Since we are filtering some of the variations client side and the variation quantity in the products endpoint includes all the variation. It's error prone to display the exact amount of variation a variable product contains after client side filtering (this filtering happens in the variations screen).
For this reasons, we decided to display "Options available" instead of variation quantity in products screen and remove variation quantity from the toolbar in variations screen.
More context: pdfdoF-62l-p2#comment-7224
Steps to reproduce
Products screen
Variations screen
The tests that have been performed
Tested both the screens on both light and dark mode
Images/gif
variation_quantity_removed.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: