Update function usage in SSR and remove need for commons-io

[hafizrahman]

Description

While looking at the Dependabot PR #13044 , I investigated a little bit and found that the dependency common-io was used just for a function in WCSSRModelExt. Then I found from Stack Overflow a function that can replace it without the need for the dependency:

https://stackoverflow.com/a/5599842

This PR adds that function and unit tests, replaces the usage, and removes the dependency.

Steps to reproduce

• Make sure unit tests pass
• Go to More Menu > Help & Support > System Status Report, and ensure these are showing correct values:
  • WordPress Environment > WP Memory Limit
  • Server Environment > PHP Post Max Size
  • Server Environment > Max Upload Size

Testing information

Nothing specific needed here.

The tests that have been performed

I checked the steps listed above.

Images/gif

n/a

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[wpmobilebot]

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list

Removed Dependencies
commons-io:commons-io:2.11.0

tree

-\--- commons-io:commons-io:2.11.0

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	c616faf
	Direct Download	woocommerce-wear-prototype-build-pr13073-c616faf.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	c616faf
	Direct Download	woocommerce-prototype-build-pr13073-c616faf.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.41%. Comparing base (c891053) to head (c616faf).
Report is 10 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...om/woocommerce/android/extensions/WCSSRModelExt.kt	0.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #13073   +/-   ##
=========================================
  Coverage     40.41%   40.41%           
  Complexity     6194     6194           
=========================================
  Files          1294     1294           
  Lines         74479    74485    +6     
  Branches      10188    10189    +1     
=========================================
+ Hits          30097    30103    +6     
  Misses        41771    41771           
  Partials       2611     2611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[irfano]

I'm thinking if we should use com.zendesk.util.FileUtils.humanReadableFileSize.humanReadableFileSize() since we're already using this Zendes library for other purposes. This would save us from adding new code to the repository, but it would still use an unnecessary dependency. I wonder about your opinion.

[hafizrahman]

I'm thinking if we should use com.zendesk.util.FileUtils.humanReadableFileSize.humanReadableFileSize() since we're already using this Zendes library for other purposes. This would save us from adding new code to the repository, but it would still use an unnecessary dependency. I wonder about your opinion.

Nice find, I did not know about that before. For this purpose I think it's better to not add dependency as it would save time in the future dealing with dependabot. I don't think the added new code will need a lot of maintenance, and it's also only used in one small part of the app. What do you think?

[irfano]

For this purpose I think it's better to not add dependency as it would save time in the future dealing with dependabot. I don't think the added new code will need a lot of maintenance, and it's also only used in one small part of the app. What do you think?

I agree. Let’s proceed with adding this PR. I’ve approved it, but I won’t merge it yet to give you a chance to address the feedback I provided.

I noticed a bug in the current release. We're rounding 1.99 GB to 1 GB. We're also fixing it with this PR. I guess it's not a critical issue and no need to report it to HEs.

before	after	web

[hafizrahman]

I noticed a bug in the current release. We're rounding 1.99 GB to 1 GB. We're also fixing it with this PR. I guess it's not a critical issue and no need to report it to HEs.

Great catch, thanks for testing so thoroughly! I think it's nothing we should announce, but great that it's fixed as a side effect.