Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commons-io:commons-io from 2.11.0 to 2.18.0 #13044

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 2, 2024

Bumps commons-io:commons-io from 2.11.0 to 2.18.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps commons-io:commons-io from 2.11.0 to 2.18.0.

---
updated-dependencies:
- dependency-name: commons-io:commons-io
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Dec 2, 2024
@dependabot dependabot bot requested review from a team and hichamboushaba and removed request for a team December 2, 2024 18:28
@wpmobilebot
Copy link
Collaborator

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list
Upgraded Dependencies
commons-io:commons-io:2.18.0, (changed from 2.11.0)
tree
-\--- commons-io:commons-io:2.11.0
+\--- commons-io:commons-io:2.18.0

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit3a39db2
Direct Downloadwoocommerce-wear-prototype-build-pr13044-3a39db2.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit3a39db2
Direct Downloadwoocommerce-prototype-build-pr13044-3a39db2.apk

@hafizrahman hafizrahman requested review from hafizrahman and removed request for hichamboushaba December 5, 2024 05:45
@hafizrahman hafizrahman self-assigned this Dec 5, 2024
@hafizrahman
Copy link
Contributor

hafizrahman commented Dec 5, 2024

Taking over to review this.

commons-io release notes: https://commons.apache.org/proper/commons-io/changes-report.html

Release 2.11.0 – 2021-07-09
Release 2.18.0 – 2024-11-16

@hafizrahman hafizrahman added this to the 21.3 milestone Dec 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.33%. Comparing base (4a8ef34) to head (3a39db2).
Report is 72 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13044      +/-   ##
============================================
- Coverage     40.34%   40.33%   -0.01%     
+ Complexity     6161     6160       -1     
============================================
  Files          1287     1287              
  Lines         74156    74156              
  Branches      10143    10143              
============================================
- Hits          29915    29914       -1     
  Misses        41651    41651              
- Partials       2590     2591       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hafizrahman
Copy link
Contributor

After looking at the code, I found that this dependency was added (by me, huh) just for a single function call in the SSR screen.

I'm closing this PR in favor of this PR #13073 , that adds an alternative function. That way we don't have to add this dependency anymore and not have to deal with upgrading it.

@hafizrahman hafizrahman closed this Dec 5, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 5, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/commons-io-commons-io-2.18.0 branch December 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: dependencies update PRs that update a dependency file, used by Dependabot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants