This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Replace deprecated isPrimary, isSecondary, isTertiary, isLink Button props with variant #8340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moon0326 Thanks for the review! 🙇♂️ I just found this is not compatible with WP 5.8. 😞 And this is why the e2e test failed. I'm going to close this for now since our min support version is 5.6. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8313
This PR updates the deprecated isPrimary, isSecondary, isTertiary, isLink Button props.
Document Reference: https://github.com/WordPress/gutenberg/tree/trunk/packages/components/src/button#variant
Screenshots
primary, link
primary, secondary, tertiary
Detailed test instructions:
Review the other code changes