Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Some props in @wordpress/components <Button> are deprecated #8313

Closed
chihsuan opened this issue Feb 15, 2022 · 1 comment
Closed

Some props in @wordpress/components <Button> are deprecated #8313

chihsuan opened this issue Feb 15, 2022 · 1 comment
Assignees
Labels
type: refactor The issue/PR is related to refactoring. type: task The issue is an internally driven task (e.g. from another A8c team). type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@chihsuan
Copy link
Member

Describe the bug

We should use the variant prop instead for <Button>.

https://github.com/WordPress/gutenberg/blob/81e8e0f7c999df3cc43ef97cb2913779c0190eff/packages/components/CHANGELOG.md#deprecation-1

isPrimary, isSecondary, isTertiary and isLink props in Button have been deprecated. Use variant instead (#31713).

#8305 (review)

@wordpress/components deprecated some props (isPrimary, isSecondary, isTertiary, isLink) in <Button> and we use those props, so we should probably make a separate issue to fix them before they completely remove support.

@chihsuan chihsuan added type: technical debt This issue/PR represents/solves the technical debt of the project. type: task The issue is an internally driven task (e.g. from another A8c team). type: refactor The issue/PR is related to refactoring. labels Feb 15, 2022
@chihsuan chihsuan self-assigned this Feb 22, 2022
@chihsuan
Copy link
Member Author

I found this is not compatible with WP 5.8 because @wordpress/components in 5.8 is still old version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor The issue/PR is related to refactoring. type: task The issue is an internally driven task (e.g. from another A8c team). type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
1 participant