Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Button: Remove deprecated isDefault #4548

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Button: Remove deprecated isDefault #4548

merged 2 commits into from
Jun 11, 2020

Conversation

psealock
Copy link
Collaborator

Fixes #4538

@wordpress/components has deprecated isDefault for buttons. This PR replaces it with isSecondary unless there already is isPrimary prop.

Detailed test instructions:

  1. Click around the app and see that buttons are rendering correctly.

Changelog Note:

none: fixes unreleased issues

@psealock psealock requested a review from a team June 11, 2020 01:31
jeffstieler
jeffstieler approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@psealock psealock merged commit 82208f1 into master Jun 11, 2020
@psealock psealock deleted the fix/button-styles branch June 11, 2020 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffstieler jeffstieler jeffstieler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button: remove isDefault in favor of isSecondary and tidy up
2 participants
@psealock @jeffstieler