Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Button: remove isDefault in favor of isSecondary and tidy up #4538

Closed
psealock opened this issue Jun 10, 2020 · 0 comments · Fixed by #4548
Closed

Button: remove isDefault in favor of isSecondary and tidy up #4538

psealock opened this issue Jun 10, 2020 · 0 comments · Fixed by #4548
Assignees
@psealock

Comments

@psealock
Copy link
Collaborator

psealock commented Jun 10, 2020 •
edited
Loading

isDefault has been deprecated:

Button isDefault prop is deprecated. Please use isSecondary instead.

This issue is to track that.

Also, some other styles are off. We should use the buttons as they are without changing things like color or padding.
@psealock psealock mentioned this issue Jun 10, 2020
Merged
@psealock psealock changed the title Button: remove isDefault in favor of isSecondary Button: remove isDefault in favor of isSecondary and tidy up Jun 10, 2020
@psealock psealock self-assigned this Jun 11, 2020
@psealock psealock mentioned this issue Jun 11, 2020
Merged
@dechov dechov mentioned this issue Jun 11, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@psealock psealock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Button: Remove deprecated isDefault woocommerce/woocommerce-admin
1 participant
@psealock