-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version of @wordpress/components #717
Comments
The dependency version in |
The bundling of |
@dechov @vbelolapotkov While working on #1378 I noted that the outdated version of @wordpress/components as well as the base components are preventing us from being able to use the correct I believe @jessepearson may have also encountered this issue while he was working on styling for instant deposits. We should consider re-prioritizing this issue ASAP. |
I have just encountered this as well while working on #1501. |
There is a draft PR created but some UI is failing atm due to various deprecations in components props. |
@vbelolapotkov Thank you! In the meantime, what is the best course of action to get the current component styles without updating the version numbers? Should I wait for the PR to be merged or backport the button styles? |
@waclawjacek it depends on the timeline and importance for your PR/feature. If you want it to go live with next release (2.3.0), it's better to copy components/styles you need and create a follow up issue to address once the components package is updated. If it can wait and can be blocked until package is updated, you can build on top of #1536 (I plan to update it soon to make more usable). |
In #571, a severe styling regression from a WP update was dealt with by pinning our version of
@wordpress/components
to what WooCommerce Admin was using at the time (8.5.0). Now the latter version has been updated as well (see woocommerce/woocommerce-admin#4427).We should follow suit and update our version (or possibly consider using the external dependency again, despite being demonstrably riskier), which should no longer cause the issue solved in #571, though we'll need to consider newer WCPay releases' compatibility with older WooCommerce Admin versions.
(See also woocommerce/woocommerce-admin#4538.)
The text was updated successfully, but these errors were encountered: