Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of @wordpress/components #717

Closed
dechov opened this issue Jun 11, 2020 · 7 comments · Fixed by #1536
Closed

Update version of @wordpress/components #717

dechov opened this issue Jun 11, 2020 · 7 comments · Fixed by #1536
Labels
size: medium The issue is sized medium. status: has pr The issue has a PR.

Comments

@dechov
Copy link
Contributor

dechov commented Jun 11, 2020

In #571, a severe styling regression from a WP update was dealt with by pinning our version of @wordpress/components to what WooCommerce Admin was using at the time (8.5.0). Now the latter version has been updated as well (see woocommerce/woocommerce-admin#4427).

We should follow suit and update our version (or possibly consider using the external dependency again, despite being demonstrably riskier), which should no longer cause the issue solved in #571, though we'll need to consider newer WCPay releases' compatibility with older WooCommerce Admin versions.

(See also woocommerce/woocommerce-admin#4538.)

@reykjalin reykjalin added the size: small The issue is sized small. label Jul 23, 2020
@dechov
Copy link
Contributor Author

dechov commented Oct 27, 2020

The dependency version in woocommerce-admin was now most recently bumped in woocommerce/woocommerce-admin#5293, causing some styling regressions (woocommerce/woocommerce-admin#5345) currently being addressed.

@dechov
Copy link
Contributor Author

dechov commented Feb 12, 2021

The bundling of @wordpress/components in WC Admin was removed altogether in woocommerce/woocommerce-admin#5753.

@LevinMedia
Copy link
Contributor

LevinMedia commented Mar 8, 2021

@dechov @vbelolapotkov While working on #1378 I noted that the outdated version of @wordpress/components as well as the base components are preventing us from being able to use the correct isSecondary button styles in the disputes section.

I believe @jessepearson may have also encountered this issue while he was working on styling for instant deposits. We should consider re-prioritizing this issue ASAP.

@waclawjacek
Copy link
Contributor

While working on #1378 I noted that the outdated version of @wordpress/components as well as the base components are preventing us from being able to use the correct isSecondary button styles in the disputes section.

I have just encountered this as well while working on #1501.

@vbelolapotkov vbelolapotkov added status: has pr The issue has a PR. size: medium The issue is sized medium. and removed size: small The issue is sized small. labels Apr 9, 2021
@vbelolapotkov
Copy link
Collaborator

There is a draft PR created but some UI is failing atm due to various deprecations in components props.

@waclawjacek
Copy link
Contributor

@vbelolapotkov Thank you! In the meantime, what is the best course of action to get the current component styles without updating the version numbers? Should I wait for the PR to be merged or backport the button styles?

@vbelolapotkov
Copy link
Collaborator

@waclawjacek it depends on the timeline and importance for your PR/feature. If you want it to go live with next release (2.3.0), it's better to copy components/styles you need and create a follow up issue to address once the components package is updated. If it can wait and can be blocked until package is updated, you can build on top of #1536 (I plan to update it soon to make more usable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: medium The issue is sized medium. status: has pr The issue has a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants