-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GTIN] Hide GTIN in product editor #2690
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2690 +/- ##
=========================================
Coverage 64.7% 64.7%
- Complexity 4665 4667 +2
=========================================
Files 799 799
Lines 24640 24645 +5
Branches 1242 1242
=========================================
+ Hits 15938 15944 +6
+ Misses 8529 8528 -1
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I tested all combinations of versions both with Yoast enabled and disabled, and I'm getting the expected results.
Both the unit tests and E2E tests pass locally now as well.
I'll go ahead and approved the PR. If there aren't any drastic changes with setting gla_install_version
during E2E testing and changing the expected fields, then I'm ok with getting the PR merged without an additional review. We'll need to have it ready early on Monday to not block any of the other branches being released.
Changes proposed in this Pull Request:
Closes part of #2684
This PR fixes a bug in which GTIN field was not hidden or disabled in Product Block Editor. Additionally fixes some e2e tests in product editor and classic editor
Screenshots:
Detailed test instructions:
gla_install_version
as < 2.8.8gla_install_version
as >= 2.8.8Additional details:
Changelog entry