Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support core gtin field #2684

Merged
merged 91 commits into from
Nov 22, 2024
Merged

Support core gtin field #2684

merged 91 commits into from
Nov 22, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Nov 21, 2024

Changes proposed in this Pull Request:

Closes #2617

This PR contains all the PRs for the GTIN Migration.

Additional details:

Changelog entry

Update - Hide or disable GTIN field in favor of the new native GTIN located in the WooCommerce Product Inventory tab

martynmjones and others added 30 commits September 20, 2024 10:40
…-gtin-field-in-product-adapter

Prioritise core WooCommerce GTIN field in product adapter
puntope and others added 19 commits November 8, 2024 09:41
…roller

[GTIN] GTIN Migration API Controller
[GTIN] Add WP CLI command for migration
Refactor & fix undesired exceptions in AS Jobs
[GTIN] Adjust plugin version for hidding GTIN
[GTIN] Add Migration support for YOAST SEO
[GTIN] Adding more tests for GTIN migration
@puntope puntope self-assigned this Nov 21, 2024
@github-actions github-actions bot added type: enhancement The issue is a request for an enhancement. changelog: add A new feature, function, or functionality was added. labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 44.51039% with 187 lines in your changes missing coverage. Please review.

Project coverage is 64.7%. Comparing base (0383264) to head (934d0bc).
Report is 113 commits behind head on develop.

Files with missing lines Patch % Lines
src/Utility/WPCLIMigrationGTIN.php 0.0% 85 Missing ⚠️
...c/API/Site/Controllers/GTINMigrationController.php 50.9% 26 Missing ⚠️
...nts/gtin-migration-banner/gtin-migration-banner.js 34.3% 23 Missing ⚠️
src/ConnectionTest.php 0.0% 7 Missing ⚠️
src/HelperTraits/GTINMigrationUtilities.php 75.9% 7 Missing ⚠️
src/Admin/Input/SelectWithTextInput.php 14.3% 6 Missing ⚠️
js/src/data/resolvers.js 0.0% 5 Missing ⚠️
...ternal/DependencyManagement/JobServiceProvider.php 0.0% 5 Missing ⚠️
src/Jobs/MigrateGTIN.php 88.6% 5 Missing ⚠️
js/src/data/reducer.js 0.0% 3 Missing ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2684      +/-   ##
============================================
+ Coverage       62.7%   64.7%    +2.0%     
- Complexity         0    4665    +4665     
============================================
  Files            319     799     +480     
  Lines           5074   24640   +19566     
  Branches        1231    1242      +11     
============================================
+ Hits            3180   15938   +12758     
- Misses          1721    8529    +6808     
  Partials         173     173              
Flag Coverage Δ
js-unit-tests 62.4% <38.6%> (-0.3%) ⬇️
php-unit-tests 65.3% <45.7%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/components/main-tab-nav/main-tab-nav.js 90.0% <100.0%> (ø)
js/src/data/action-types.js 100.0% <ø> (ø)
js/src/data/selectors.js 48.5% <100.0%> (+1.0%) ⬆️
src/Admin/Product/Attributes/Input/GTINInput.php 100.0% <100.0%> (ø)
...ernal/DependencyManagement/RESTServiceProvider.php 100.0% <100.0%> (ø)
...ernal/DependencyManagement/CoreServiceProvider.php 0.0% <0.0%> (ø)
src/Internal/InstallTimestamp.php 0.0% <0.0%> (ø)
src/Product/WCProductAdapter.php 97.7% <87.5%> (ø)
js/src/data/actions.js 7.9% <0.0%> (-0.1%) ⬇️
js/src/hooks/useGTINMigrationStatus.js 77.8% <77.8%> (ø)
... and 13 more

... and 463 files with indirect coverage changes

---- 🚨 Try these New Features:

@puntope puntope marked this pull request as ready for review November 22, 2024 09:07
@puntope puntope merged commit 5d03086 into develop Nov 22, 2024
15 checks passed
@puntope puntope deleted the add/support-core-gtin-field branch November 22, 2024 09:10
@ianlin ianlin mentioned this pull request Nov 26, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GTIN] Retire the existing Global Trade Item Number field in Google for WooCommerce
2 participants