Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix #35

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Bug fix #35

merged 5 commits into from
Dec 19, 2024

Conversation

david-i-berry
Copy link
Member

@david-i-berry david-i-berry commented Dec 6, 2024 •
edited
Loading

Fixes #27, #28, and #30

Test docker workflow updated so downloads repeatable without hash check failing.

(and thanks to Aissa @AissaGeek for spotting the issues/proposing solutions)

@david-i-berry
Addresses:
4474942 
- #32 (http 200 check)
- #30 (integrity field)
- #27 (hash function)

Fixes path issues in Dockerfile.
@david-i-berry
Alignment with recent PR to address #32.
1b0167c
@david-i-berry
Addresses:
95efd0c 
- #30 (integrity field)
- #27 (hash function)

Fixes path issues in Dockerfile.
@david-i-berry
Reversion of dockerfile, presvious commit causes issues in automated …
ae116a5 
…tests
@david-i-berry
tests updated so reproducible download.
da93174
@tomkralidis tomkralidis merged commit fb559cf into main Dec 19, 2024
18 checks passed
@tomkralidis tomkralidis deleted the bug-fix branch December 19, 2024 12:47
This was referenced Jan 6, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkralidis tomkralidis tomkralidis approved these changes

@maaikelimper maaikelimper Awaiting requested review from maaikelimper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: 'hashlib.HASH' object is not callable in validate_data method
2 participants
@david-i-berry @tomkralidis