Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wis2downloader should detect HTML code != 200 and log ERROR rather than creating fake downloads #32

Closed
maaikelimper opened this issue Dec 3, 2024 · 2 comments
Closed

wis2downloader should detect HTML code != 200 and log ERROR rather than creating fake downloads #32

maaikelimper opened this issue Dec 3, 2024 · 2 comments
Assignees
@alimand
Labels
bug Something isn't working

Comments

@maaikelimper
Copy link
Collaborator

image

image
@maaikelimper maaikelimper added the bug Something isn't working label Dec 3, 2024
@maaikelimper
Copy link
Collaborator Author

In these lines:
https://github.com/wmo-im/wis2downloader/blob/main/wis2downloader/downloader/__init__.py#L184-L186

we should check the status before storing the data

@maaikelimper maaikelimper mentioned this issue Dec 3, 2024
Closed
@maaikelimper maaikelimper changed the title wis2downloader should detect 4XX and log ERROR rather than creating fake downloads wis2downloader should detect HTML code != 200 and log ERROR rather than creating fake downloads Dec 3, 2024
@alimand
Copy link
Collaborator

alimand commented Dec 6, 2024

Please see: #34

david-i-berry added a commit that referenced this issue Dec 6, 2024
@david-i-berry
Addresses:
4474942 
- #32 (http 200 check)
- #30 (integrity field)
- #27 (hash function)

Fixes path issues in Dockerfile.
david-i-berry added a commit that referenced this issue Dec 6, 2024
@david-i-berry
Alignment with recent PR to address #32.
1b0167c
tomkralidis pushed a commit that referenced this issue Dec 19, 2024
@david-i-berry
Bug fix (#35)
fb559cf 
* Addresses:
- #32 (http 200 check)
- #30 (integrity field)
- #27 (hash function)

Fixes path issues in Dockerfile.

* Alignment with recent PR to address #32.

* Addresses:
- #30 (integrity field)
- #27 (hash function)

Fixes path issues in Dockerfile.

* tests updated so reproducible download.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimand alimand

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maaikelimper @alimand