Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define business process for adding new centres/centre-id #21

Closed
amilan17 opened this issue Jan 11, 2023 · 14 comments · Fixed by #78
Closed

define business process for adding new centres/centre-id #21

amilan17 opened this issue Jan 11, 2023 · 14 comments · Fixed by #78
Assignees
Milestone

Comments

@amilan17
Copy link
Member

amilan17 commented Jan 11, 2023

use case:

  • WCMP2 validation of topic hierarchy will need to check the centre_id before it's approved by WMO

ideas:

  • add status column to topic hierarchy CSVs
  • branch and PR workflows
@amilan17 amilan17 changed the title add status column to topic hierarchy CSVs management of topic values Jan 11, 2023
@tomkralidis
Copy link
Collaborator

TT-WISMD 2023-02-15:

  • discuss with @efucile @golfvert on formality of approval process/options/governance (pull request? National PR approval? Something else?)

@golfvert
Copy link
Contributor

  • center_id

Anna, while the decision is still fresh, we go for centre-id, can you change your text? Just to avoid confusion on what is what !

@amilan17 amilan17 changed the title management of topic values Governance of topic values Feb 17, 2023
@amilan17 amilan17 changed the title Governance of topic values Governance of level 9+ sub-categories Feb 17, 2023
@amilan17 amilan17 changed the title Governance of level 9+ sub-categories Governance of topics Feb 17, 2023
@amilan17 amilan17 changed the title Governance of topics Governance of topics vs availability for use Feb 17, 2023
@tomkralidis
Copy link
Collaborator

TT-WISMD 2023-04-12:

  • once we get into FT workflow, we need to consider a fulsome list so that centres are not blocked from producing data
  • can we add a status column to the centre-id (active, planned, etc.)
  • need historical centre-id's for centres who stop providing data (for delayed mode/climate applications)
  • FT workflow: delay in approval
  • monitoring can help here to trigger centre-id publication for corrective action
    • gets added at next FT
  • security implications?
    • centre-id needs to be approved by PR
    • being approved / registered is a pre-cursor to data publication
    • need trigger/notification to TT-WISMD to add centre-ids

@efucile
Copy link
Member

efucile commented Apr 17, 2023

  • We are still in the pilot phase, and things are not properly governed. We need to have a registration process for centre-id and when WIS2 will be operational GB should not allow topics with unofficial centre-id.
  • When a center-id is defined it is forever, therefore I don't think there is the need of historical centre-id's.
  • FT is not enough or not the way to approve a centre-id

@amilan17 amilan17 moved this from Todo to Backlog in TT-WISMD issues from multiple repos Jun 22, 2023
@tomkralidis tomkralidis changed the title Governance of topics vs availability for use define business process for adding new centres/centre-id Sep 12, 2023
@amilan17
Copy link
Member Author

@kurt-hectic FYI, we will be adding centre-ids to the TH

@6a6d74 6a6d74 moved this to Uncategorized in WIS2 - the everything list Oct 6, 2023
@golfvert golfvert moved this from Uncategorized to For INFCOM3 (Apr 2024) in WIS2 - the everything list Oct 10, 2023
@efucile
Copy link
Member

efucile commented Nov 14, 2023

Decision

This is part of the WIS2 node registration and the centre-id will be kept in the WIS2 registry.

@golfvert
Copy link
Contributor

20231013_Adding_NC_WIS2.pdf
20231013_Adding_WIS2_Node.pdf

This will need some tweaking, but the overall process is agreed as described here.

@amilan17
Copy link
Member Author

We still need to address how/when the centre-id is added to the topic-hierarchy.

Centre-ids...

  1. are requested by the center
  2. approved by WMO
  3. managed in the WIS2 Registry

I think these are the options available for implementation in the WTH
a. centre-id is added to the WTH in GitHub immediately and a new minor version of the WTH is released soon after
b. centre-id in TH is approved through fast-track approval ~2x/year
c. WIS2 Registry updates the WTH as needed/on a schedule, new minor version of WTH is released on a schedule

@golfvert
Copy link
Contributor

I'd go for a. and I don't think the concept of minor version of the WTH exists and we don't need it either.
So "a. centre-id is added to the WTH in GitHub immediately" and done.

@tomkralidis
Copy link
Collaborator

So "a. centre-id is added to the WTH in GitHub immediately" and done.

This change then needs to propagate schemas.wmo.int as well as possibly elsewhere, for those doing WTH validation. Which means even with a, we will need to apply minor version update somehow and communicate.

@tomkralidis
Copy link
Collaborator

Related: wmo-im/wis2-guide#51

@golfvert
Copy link
Contributor

golfvert commented Nov 24, 2023

"for those doing WTH validation". Not necessarily. The GB when subscribing to a new centre-id will be by the mere fact of that subscription checking that the centre-id is known and correct. So checking the TH by the GB, up to that level at least, doesn't require any publication.
And, I am not sure that we will need strict TH validation elsewhere.

@tomkralidis
Copy link
Collaborator

TT-WISMD 2023-12-01:

  • WTH stable branches are as per FT approval
  • if there is an update to WTH that involves an addition of a centre-id, a new version of WTH tables/bundle are published immediately with the new centre-id to stable branch

@tomkralidis
Copy link
Collaborator

PR in #78

@tomkralidis tomkralidis added this to the INFCOM-3 milestone Dec 1, 2023
@github-project-automation github-project-automation bot moved this from For INFCOM3 (Apr 2024) to For end of Pilot phase (Dec 2023) in WIS2 - the everything list Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants