Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): remove default cjs format #2441

Merged
merged 5 commits into from
Apr 24, 2022

Conversation

tzachbon
Copy link
Contributor

@tzachbon tzachbon commented Apr 12, 2022

BREAKING

closes #1854

@tzachbon tzachbon marked this pull request as ready for review April 13, 2022 08:43
@tzachbon tzachbon requested a review from tomrav April 13, 2022 09:01
@barak007
Copy link
Collaborator

barak007 commented Apr 13, 2022

There is another change we can make for the cli interface and that's to be able to emit output and also build index I the same command. Right now if you add indexFile it will not emit assets.
Maybe should be added to the v5 issue

@tzachbon
Copy link
Contributor Author

There is another change we can make for the cli interface and that's to be able to emit output and also build index I the same command. Right now if you add indexFile it will not emit assets. Maybe should be added to the v5 issue

Agreed, I'll add it to the issue and we will change it in a different PR.

@tzachbon tzachbon requested a review from tomrav April 13, 2022 13:32
@tzachbon tzachbon merged commit 852eb33 into ido/stylable-v5 Apr 24, 2022
@tzachbon tzachbon deleted the tzach/stylable-v5/remove-cjs-from-cli branch April 24, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants