Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI should have no output module type defined by default #1854

Closed
tomrav opened this issue Jun 9, 2021 · 1 comment
Closed

CLI should have no output module type defined by default #1854

tomrav opened this issue Jun 9, 2021 · 1 comment
Assignees
@tzachbon
Labels
next-major Issues or PR related to the next major version tech debt Updates, upgrades, stale code and work-arounds tooling CLI, stylable-scripts boilerplate

Comments

@tomrav
Copy link
Collaborator

tomrav commented Jun 9, 2021

Currently when running stc the only module type that defaults to true is cjs. While this can fit some use-cases, it definitely doesn't fit all of them.

In the next major version, we can break this behavior and force the user to specify all module types they require.

Something like:

stc --modules="cjs, stcss, dts, dtsSourceMap"
@tomrav tomrav added tooling CLI, stylable-scripts boilerplate tech debt Updates, upgrades, stale code and work-arounds next-major Issues or PR related to the next major version labels Jun 9, 2021
@idoros idoros mentioned this issue Mar 27, 2022
Closed
18 tasks
@tomrav tomrav added this to Stylable Apr 11, 2022
@tomrav tomrav moved this to ❓ Triage Required in Stylable Apr 11, 2022
@tzachbon tzachbon mentioned this issue Apr 13, 2022
Merged
@tzachbon tzachbon moved this from ❓ Triage Required to ▶️ In Progress in Stylable Apr 14, 2022
@tzachbon tzachbon removed the status in Stylable Apr 25, 2022
@tzachbon
Copy link
Contributor

Fixed in #2441, and will be released in Stylable version 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzachbon tzachbon

Labels
next-major Issues or PR related to the next major version tech debt Updates, upgrades, stale code and work-arounds tooling CLI, stylable-scripts boilerplate
Projects
Stylable
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomrav @tzachbon