[WIP] Slip32 #436
Closed
[WIP] Slip32 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
requested changes
Mar 11, 2019
|
|
||
| // 33 bytes for key | ||
| // | ||
| // TODO: Find a way to get access to secp256k1::SecretKey bytes, |
There was a problem hiding this comment.
In rust-bitcoin/rust-secp256k1#75 (comment) they answer how to get the bytes out from a secret key.
You should be able to use [..] to get the bytes out of a secret key no problem. See, eg, this line in rust-lightning: https://github.com/rust-bitcoin/rust-lightning/blob/master/src/ln/chan_utils.rs#L80
Tommytrg
reviewed
Mar 11, 2019
| @@ -6,5 +6,11 @@ version = "0.1.0" | |||
| workspace = ".." | |||
|
|
|||
| [dependencies] | |||
| bip39 = "*" | |||
| bip39 = "0.6.0-beta.1" | |||
| failure = "*" | |||
There was a problem hiding this comment.
Suggested change
| failure = "*" | |
| failure = "0.1.5" |
Tommytrg
reviewed
Mar 11, 2019
| bip39 = "*" | ||
| bip39 = "0.6.0-beta.1" | ||
| failure = "*" | ||
| hmac = "*" |
There was a problem hiding this comment.
Suggested change
| hmac = "*" | |
| hmac = "0.7.0" |
Tommytrg
requested changes
Mar 11, 2019
| bip39 = "0.6.0-beta.1" | ||
| failure = "*" | ||
| hmac = "*" | ||
| secp256k1 = "*" |
There was a problem hiding this comment.
Suggested change
| secp256k1 = "*" | |
| secp256k1 = "0.12.2" |
| failure = "*" | ||
| hmac = "*" | ||
| secp256k1 = "*" | ||
| sha2 = "*" |
There was a problem hiding this comment.
Suggested change
| sha2 = "*" | |
| sha2 = "0.8.0" |
| hmac = "*" | ||
| secp256k1 = "*" | ||
| sha2 = "*" | ||
| bech32 = "*" |
There was a problem hiding this comment.
Suggested change
| bech32 = "*" | |
| bech32 = "0.6.0" |
| tiny-hderive = "*" | ||
| endianrw = "*" |
There was a problem hiding this comment.
Suggested change
| endianrw = "*" | |
| endianrw = "0.2.2" |
| hmac = "*" | ||
| secp256k1 = "*" | ||
| sha2 = "*" | ||
| bech32 = "*" | ||
| tiny-hderive = "*" |
There was a problem hiding this comment.
Suggested change
| tiny-hderive = "*" | |
| tiny-hderive = "0.1.0" |
|
|
||
| /// Use the given key as the HMAC key | ||
| pub fn with_key(mut self, key: &'a str) -> Self { | ||
| self.key = key; |
There was a problem hiding this comment.
Suggested change
| self.key = key; | |
| self.key = key; | |
|
It is included in #432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export/import keys to Slip32 format.
I'm stuck in: see TODO comment in
wallet/src/slip32.rsfile