Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13 tracking issue #75

Closed
8 tasks done
apoelstra opened this issue Oct 27, 2018 · 10 comments
Closed
8 tasks done

0.13 tracking issue #75

apoelstra opened this issue Oct 27, 2018 · 10 comments

Comments

@apoelstra
Copy link
Member

apoelstra commented Oct 27, 2018

Breaking changes for 0.12:

  • Change serde serialization for human-readable formats to hex encodings
  • Upgrade upstream libsecp to one with add static context object which has no capabilities bitcoin-core/secp256k1#553
  • Remove &Secp256k1 arg from all functions that use a no-caps context, use the static one instead.
  • Remove the key::ZERO constant since this can be used to trigger assertation failures.
  • Change second argument to add_assign and mul_assign from a SecretKey to a &[u8]
  • Feature-gate recovery module

Nonbreaking changes we should also do:

@real-or-random
Copy link
Collaborator

* [ ]  Make `add_assign` and `mul_assign` actually use the `AddAssign` and `MulAssign` traits; we should also implement `Add` and `Mul` for that matter.

I don't think that works because add_assign and mul_assign can fail and the trait doesn't support that.

@apoelstra
Copy link
Member Author

@real-or-random if we define a trait that describes hash functions (or something), then we can define these those functions for those objects. Then they could only fail with negligible probability and we don't need to worry about it.

@real-or-random
Copy link
Collaborator

Indeed. But then this is just different functionality, no?

@apoelstra
Copy link
Member Author

Yeah. I'll remove it from the tracking list because it's probably a post-0.12 thing to figure that out.

@sgeisler
Copy link
Contributor

sgeisler commented Dec 7, 2018

Can this issue be closed since 0.12.0 was released?

@apoelstra
Copy link
Member Author

No, there are still a couple things I want to do

@apoelstra apoelstra changed the title 0.12 tracking issue 0.13 tracking issue Dec 8, 2018
@vlad9486
Copy link

Second argument to add_assign is important for revocation keys derivation for Lightning. There is no way to convert SecretKey into raw bytes, so there is no legitimate (safe) way to perform secret key derivation.

@TheBlueMatt
Copy link
Member

TheBlueMatt commented Jan 22, 2019 via email

@vlad9486
Copy link

Thanks, @TheBlueMatt, I missed this.

@apoelstra
Copy link
Member Author

All done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants