-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.13 tracking issue #75
Comments
I don't think that works because |
@real-or-random if we define a trait that describes hash functions (or something), then we can define these those functions for those objects. Then they could only fail with negligible probability and we don't need to worry about it. |
Indeed. But then this is just different functionality, no? |
Yeah. I'll remove it from the tracking list because it's probably a post-0.12 thing to figure that out. |
Can this issue be closed since |
No, there are still a couple things I want to do |
Second argument to |
You should be able to use [..] to get the bytes out of a secret key no problem. See, eg, this line in rust-lightning: https://github.com/rust-bitcoin/rust-lightning/blob/master/src/ln/chan_utils.rs#L80
… On Jan 22, 2019, at 18:34, Vladislav Melnik ***@***.***> wrote:
Second argument to add_assign is important for revocation keys derivation for Lightning. There is no way to convert SecretKey into raw bytes, so there is no legitimate (safe) way to perform secret key derivation.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks, @TheBlueMatt, I missed this. |
All done :) |
Breaking changes for 0.12:
&Secp256k1
arg from all functions that use a no-caps context, use the static one instead.key::ZERO
constant since this can be used to trigger assertation failures.add_assign
andmul_assign
from aSecretKey
to a&[u8]
Nonbreaking changes we should also do:
Display
andFromStr
for all types that do hex-encoding addFromStr
implementation for key types #60Secp256k1::without_caps()
which no longer has any useThe text was updated successfully, but these errors were encountered: