Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ja): translated components section + alpha #2384

Merged
merged 62 commits into from
Sep 26, 2024

Conversation

Kenzo-Wada
Copy link
Contributor

Description

  • translated all files of components section, and reference/icons.mdx

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 18d9278

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 5a57753
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66f58a1585718600096bd0be
😎 Deploy Preview https://deploy-preview-2384--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Sep 20, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Sep 20, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ja components/asides.mdx Localization added, will be marked as complete.
ja components/badges.mdx Localization added, will be marked as complete.
ja components/card-grids.mdx Localization added, will be marked as complete.
ja components/cards.mdx Localization added, will be marked as complete.
ja components/code.mdx Localization added, will be marked as complete.
ja components/file-tree.mdx Localization added, will be marked as complete.
ja components/icons.mdx Localization added, will be marked as complete.
ja components/link-buttons.mdx Localization added, will be marked as complete.
ja components/link-cards.mdx Localization added, will be marked as complete.
ja components/steps.mdx Localization added, will be marked as complete.
ja components/tabs.mdx Localization added, will be marked as complete.
ja components/using-components.mdx Localization added, will be marked as complete.
ja guides/authoring-content.mdx Localization added, will be marked as complete.
ja reference/icons.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@Kenzo-Wada
Copy link
Contributor Author

Hi, @delucis!

Please review this PR when you have time!

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the new translations 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left quite a bit of comments or suggestions altho considering the size of the PR, it's fairly minimal. Most of the comments are about consistency, making sure all the examples are translated and always linking to translated content when available.

Let me know if you have any questions.

@@ -0,0 +1,154 @@
---
title: アサイド
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that in the previous version of the documentation, we were using "補足情報".

Is the change expected or one is better than the other? Let me know what you think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0321c2e

This was the part I was just struggling with when I implemented it...

I initially named it “アサイド” because I thought it would be better to treat it like a proper noun, but if you had documented it that way before, I think I'll use that name for now! sounds nice:)

docs/src/content/docs/ja/components/asides.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ja/components/asides.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ja/components/asides.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ja/components/asides.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ja/components/using-components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ja/guides/authoring-content.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ja/guides/authoring-content.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ja/components/link-cards.mdx Outdated Show resolved Hide resolved
@Kenzo-Wada Kenzo-Wada force-pushed the chore/i18n-ja-components branch from 0ed18cd to 1646d9d Compare September 24, 2024 15:48
@Kenzo-Wada Kenzo-Wada requested a review from HiDeoo September 24, 2024 15:54
@Kenzo-Wada
Copy link
Contributor Author

Kenzo-Wada commented Sep 24, 2024

Hi @HiDeoo

Thank you for your kind review!
I have made corrections to the ones you commented on and would be happy if you'd take another look at them!

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually fixing a tiny missed translation.

docs/src/content/docs/ja/components/using-components.mdx Outdated Show resolved Hide resolved
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes, I hope the amount was not too frightening. This looks amazing to me now, great job 🚀 🌟

Small additional note: if you're interested in a small follow-up PR, the "Preview" label visible above all previews in the component pages can be translated.

image

It uses a custom UI string that can be translated by creating a file like this example for the Korean version. Here is an example PR if you're interested in doing it.

@HiDeoo HiDeoo merged commit 9e4e013 into withastro:main Sep 26, 2024
15 checks passed
@Kenzo-Wada
Copy link
Contributor Author

Thanx a lot! I'll create a PR for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants