-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(ja): translated components
section + alpha
#2384
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hi, @delucis! Please review this PR when you have time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the new translations 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left quite a bit of comments or suggestions altho considering the size of the PR, it's fairly minimal. Most of the comments are about consistency, making sure all the examples are translated and always linking to translated content when available.
Let me know if you have any questions.
@@ -0,0 +1,154 @@ | |||
--- | |||
title: アサイド |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that in the previous version of the documentation, we were using "補足情報".
Is the change expected or one is better than the other? Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the part I was just struggling with when I implemented it...
I initially named it “アサイド” because I thought it would be better to treat it like a proper noun, but if you had documented it that way before, I think I'll use that name for now! sounds nice:)
Co-authored-by: HiDeoo <[email protected]>
Co-authored-by: HiDeoo <[email protected]>
Co-authored-by: HiDeoo <[email protected]>
0ed18cd
to
1646d9d
Compare
Hi @HiDeoo Thank you for your kind review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually fixing a tiny missed translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the fixes, I hope the amount was not too frightening. This looks amazing to me now, great job 🚀 🌟
Small additional note: if you're interested in a small follow-up PR, the "Preview" label visible above all previews in the component pages can be translated.
It uses a custom UI string that can be translated by creating a file like this example for the Korean version. Here is an example PR if you're interested in doing it.
Thanx a lot! I'll create a PR for that! |
Description
components
section, andreference/icons.mdx