Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ja): icons reference #2381

Closed
wants to merge 1 commit into from

Conversation

Kenzo-Wada
Copy link
Contributor

Description

  • updated: icons.mdx

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: fd1dca7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit fd1dca7
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66ed817c2f10a90008d7b46b
😎 Deploy Preview https://deploy-preview-2381--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Collaborator

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ja reference/icons.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@Kenzo-Wada Kenzo-Wada closed this Sep 20, 2024
@delucis delucis reopened this Sep 20, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Kenzo-Wada! Was there a reason you closed it? It looks great to me ✨

Comment on lines +10 to +11
アイコンは[`<Icon>`](/components/icons/)コンポーネントを使用して表示できます。
また、[カード](/components/cards/)や[ヒーローアクション](/reference/frontmatter/#hero)などの設定のような他のコンポーネントでもよく使用されます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right we do need to update these links:

Suggested change
アイコンは[`<Icon>`](/components/icons/)コンポーネントを使用して表示できます。
また、[カード](/components/cards/)[ヒーローアクション](/reference/frontmatter/#hero)などの設定のような他のコンポーネントでもよく使用されます。
アイコンは[`<Icon>`](/ja/components/icons/)コンポーネントを使用して表示できます。
また、[カード](/ja/components/cards/)[ヒーローアクション](/ja/reference/frontmatter/#hero)などの設定のような他のコンポーネントでもよく使用されます。

After that, I think the CI should pass and the page will be ready to go.

@Kenzo-Wada
Copy link
Contributor Author

@delucis

sorry, can you plz look at this one??: #2384 ( and would be happy if this pr would be closed,,,)

the reason is, I realized i have to translates components section to solve this CI failure issue: #2381 (comment)

@Kenzo-Wada Kenzo-Wada closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants