Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next): tweak i18n #9756

Merged
merged 2 commits into from
Oct 22, 2024
Merged

feat(next): tweak i18n #9756

merged 2 commits into from
Oct 22, 2024

Conversation

florian-lefebvre
Copy link
Member

Description (required)

Puts locales before defaultLocale

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.x. See withastro/astro#12243.

@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 76fd967
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67169caa00f366000882d299
😎 Deploy Preview https://deploy-preview-9756--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

casungo
casungo suggested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@casungo casungo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor tweak :)

src/content/docs/en/guides/internationalization.mdx Outdated Show resolved Hide resolved
casungo
casungo approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@casungo casungo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sarah11918
sarah11918 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @florian-lefebvre !

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! 5.0.0-beta labels Oct 22, 2024
@florian-lefebvre florian-lefebvre merged commit afbf7c0 into 5.0.0-beta Oct 22, 2024
5 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/i18n-default-locale branch October 22, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casungo casungo casungo approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
5.0.0-beta improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florian-lefebvre @sarah11918 @casungo