feat(next): make defineConfig generic #12243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4dad468 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ematipico
approved these changes
Oct 16, 2024
ematipico
reviewed
Oct 17, 2024
ematipico
approved these changes
Oct 17, 2024
bluwy
reviewed
Oct 18, 2024
sarah11918
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Changeset looks good, but just checking that I don't see any specific error messages in this PR.
I'm fine with changing the order of locales and defaultLocale, but I'm not sure what if any docs changes would be required for this PR, since this doesn't change the fact that we do already say that the default locale must be in your list of supported locales. Happy for you to double check that in the docs repo though!
Co-authored-by: Sarah Rainsberger <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
defineConfiggeneric (backward compatible). That means that some parts of the config will be constrained by others. For example, it will ensure thati18n.defaultLocaleis one ofi18n.localesat the type levelastro/configworks, by having one source of truth (fromconfig.d.ts/config.mjstosrc/config/entrypoint.tsbeing compiled)Testing
Should still pass, I added types tests
Docs
I'll do a docs PR about i18n once approved