Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update a code snippet in guides/server-side-rendering.mdx #9700

Merged
merged 3 commits into from
Oct 16, 2024
Merged

update a code snippet in guides/server-side-rendering.mdx #9700

merged 3 commits into from
Oct 16, 2024

Conversation

ArmandPhilippot
Copy link
Contributor

@ArmandPhilippot ArmandPhilippot commented Oct 16, 2024 •
edited
Loading

Description (required)

Following the discussion in #9673, I updated two sections regarding Response in guides/server-side-rendering.mdx. This is mostly code snippet updates to show the user that he can use prerender = false and that he can also return a Response using Astro.redirect.

Related issues & labels (optional)

  • Suggested label: code snippet update

@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 72f1154
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/670fc469b61cc800085f9622
😎 Deploy Preview https://deploy-preview-9700--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 16, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/server-side-rendering.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@sarah11918
Copy link
Member

10 minutes ago... 2 commits behind.... Docs comes at you fast!

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Oct 16, 2024
@liruifengv
Copy link
Member

10 minutes ago... 2 commits behind.... Docs comes at you fast!

Haha. You can merge now

@sarah11918
Copy link
Member

Actually, @ArmandPhilippot did you want to update the file name in line 233 as well?

@ArmandPhilippot
Copy link
Contributor Author

Oh sorry, I think I wanted to go too fast. 😓 Yes I should! And maybe I should update the sentence too... I don't know why I only thought of that block.

@sarah11918
Copy link
Member

Yup, make it match the changes in the other and we're good! Less work for the translators for later! 🎉

@sarah11918 sarah11918 merged commit ce6715b into withastro:main Oct 16, 2024
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the guides/server-side-rendering.mdx branch October 16, 2024 15:10
@jsparkdev jsparkdev mentioned this pull request Oct 16, 2024
Merged
@Nin3lee Nin3lee mentioned this pull request Oct 17, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 17, 2024
@ArmandPhilippot
i18n(fr): update server-side-rendering.mdx
2864593 
See withastro#9700
@ArmandPhilippot ArmandPhilippot mentioned this pull request Oct 17, 2024
Merged
yanthomasdev added a commit that referenced this pull request Oct 18, 2024
@ArmandPhilippot @yanthomasdev
i18n(fr): update guides/server-side-rendering.mdx (#9716)
d09c3a3 
* i18n(fr): update `server-side-rendering.mdx`

See #9700

* fix typo, use Steps and small rewording

* fix typo

* fix broken links

---------

Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArmandPhilippot @astrobot-houston @sarah11918 @liruifengv