Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align images alt attribute description #8543

Merged
merged 2 commits into from
Jun 17, 2024
Merged

align images alt attribute description #8543

merged 2 commits into from
Jun 17, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Jun 17, 2024 •
edited
Loading

Aligning images alt attribute description to

docs/src/content/docs/en/tutorial/2-pages/2.mdx

Line 53 in 94f0bef

alt: 'The Astro logo on a dark background with a pink glow.'

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel Vercel
Copy link

vercel bot commented Jun 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 17, 2024 10:42am

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 17, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/2-pages/2.mdx Source changed, localizations will be marked as outdated.
en tutorial/4-layouts/2.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@garysassano garysassano changed the title align alt attributes for images align images alt attribute description Jun 17, 2024
at-the-vr
at-the-vr approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sarah11918
sarah11918 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thank you! 💪

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 17, 2024
@sarah11918 sarah11918 merged commit 2cc1332 into withastro:main Jun 17, 2024
8 checks passed
@jsparkdev jsparkdev mentioned this pull request Jun 17, 2024
Merged
@at-the-vr at-the-vr mentioned this pull request Jun 17, 2024
Closed
@100gle 100gle mentioned this pull request Jun 19, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 26, 2024
@thomasbnt
i18n(fr): Update tutorial/2-pages/2.mdx from withastro#8543
4a26b83
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 26, 2024
@thomasbnt
i18n(fr): Update tutorial/4-layouts/2.mdx from withastro#8543
4b3953c
@thomasbnt thomasbnt mentioned this pull request Jun 26, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jun 26, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update tutorials (#8678)
fe54fe9 
* i18n(fr): Update `tutorial/0-introduction/1.mdx` from #8239

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8318

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8543

* i18n(fr): Update `tutorial/3-components/1.mdx` from #8300

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8303

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8584

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8318

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8543

* i18n(fr): Update `tutorial/5-astro-api/1.mdx` from #8191

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8327

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8489

* i18n(fr): Update `tutorial/5-astro-api/4.mdx` from #8419

* i18n(fr): Fix tab

Signed-off-by: Thomas Bnt <[email protected]>

---------

Signed-off-by: Thomas Bnt <[email protected]>
Co-authored-by: Yan <[email protected]>
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-the-vr at-the-vr at-the-vr approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
code snippet update Updates a code sample: typo, outdated code etc. feedback-improvement Response to widget/Discord feedback improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garysassano @astrobot-houston @sarah11918 @at-the-vr