Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove step 4 and 6 from the tutorial #8419

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Remove step 4 and 6 from the tutorial #8419

merged 2 commits into from
Jun 3, 2024

Conversation

Jayden295
Copy link
Contributor

Description (required)

I removed step 4 and 6 of Create an .xml feed document in the tutorial because it says that rss.xml is only generated during build, even though it is also generated during development.

Related issues & labels (optional)

@Jayden295
Remove step 4 and 6 from the tutorial
f8dd709 
Fixes #8418
It is being said that rss.xml is only generated during build, while it is also generated during development.
@vercel Vercel
Copy link

vercel bot commented Jun 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 3, 2024 6:23pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 2, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/5-astro-api/4.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Ash882 ! I don't know when we updated to show this page in dev, but apparently we did! 😄

Thanks for the help keeping this updated, and welcome to Team Docs! 🥳

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 3, 2024
yanthomasdev
yanthomasdev approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Ash882!

@yanthomasdev yanthomasdev merged commit 703236b into withastro:main Jun 3, 2024
8 checks passed
@jsparkdev jsparkdev mentioned this pull request Jun 3, 2024
Merged
@huyikai huyikai mentioned this pull request Jun 3, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 26, 2024
@thomasbnt
i18n(fr): Update tutorial/5-astro-api/4.mdx from withastro#8419
26cc2d5
@thomasbnt thomasbnt mentioned this pull request Jun 26, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jun 26, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update tutorials (#8678)
fe54fe9 
* i18n(fr): Update `tutorial/0-introduction/1.mdx` from #8239

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8318

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8543

* i18n(fr): Update `tutorial/3-components/1.mdx` from #8300

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8303

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8584

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8318

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8543

* i18n(fr): Update `tutorial/5-astro-api/1.mdx` from #8191

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8327

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8489

* i18n(fr): Update `tutorial/5-astro-api/4.mdx` from #8419

* i18n(fr): Fix tab

Signed-off-by: Thomas Bnt <[email protected]>

---------

Signed-off-by: Thomas Bnt <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial says that the rss.xml can't be seen in development but it actually can be
4 participants
@Jayden295 @astrobot-houston @sarah11918 @yanthomasdev