-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update microsoft-azure.mdx to expand description and add community links #5057
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:
-
Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean! -
In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳
-
One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.
Thank you for this contribution, @blueboxes ! I took an editing pass to conform to Astro docs style, and it looks great! Before merging, I do want to confirm that the Node Version issue is still a problem. Node 16 reached end of life a couple of weeks ago, and I would be surprised if anyone were still using Node 16 as a default. This may have changed very recently, so it should be checked again to see whether this is still the case. Can you confirm that and report back? Maybe we don't even need the known issues section anymore! |
Adding the |
I have been able to re-create and confirm myself however I have been looking to see if they have plan to upgrade but could not found anything. |
@blueboxes That's good enough for me! It is just surprising, since no one is supposed to be using those older versions anymore and the EOL just happened very recently. That's the only reason I wanted to double-check: maybe something happened between the time you wrote the guidance, and I reviewed it! 😄 No reason not to get this live in docs then, although I do suspect at some point that issue will no longer be the case and we'll need to remove that. I'm sure someone will tell us when it happens. 😅 |
* i18n(fr) Update microsoft-azure.mdx Update with #5057 * Update src/content/docs/fr/guides/deploy/microsoft-azure.mdx Impeccable merci Co-authored-by: Paul Valladares <[email protected]> --------- Co-authored-by: Paul Valladares <[email protected]> Co-authored-by: Yan Thomas <[email protected]>
Description (required)
Added more descriptions and links along with a known issue/workaround
Related issues & labels (optional)