Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microsoft-azure.mdx to expand description and add community links #5057

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

blueboxes
Copy link
Contributor

Description (required)

Added more descriptions and links along with a known issue/workaround

Related issues & labels (optional)

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 69790bd
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/65353e492b0c630008333ff5
😎 Deploy Preview https://deploy-preview-5057--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918
Copy link
Member

Thank you for this contribution, @blueboxes ! I took an editing pass to conform to Astro docs style, and it looks great!

Before merging, I do want to confirm that the Node Version issue is still a problem. Node 16 reached end of life a couple of weeks ago, and I would be surprised if anyone were still using Node 16 as a default. This may have changed very recently, so it should be checked again to see whether this is still the case.

Can you confirm that and report back? Maybe we don't even need the known issues section anymore!

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. help wanted Issues looking for someone to run with them! labels Oct 16, 2023
@sarah11918
Copy link
Member

Adding the help-wanted and confirm-behaviour labels here, because I'd love for anyone to confirm that the Node version is still a problem! (See above comment)

@blueboxes
Copy link
Contributor Author

I have been able to re-create and confirm myself however I have been looking to see if they have plan to upgrade but could not found anything.

@sarah11918
Copy link
Member

@blueboxes That's good enough for me! It is just surprising, since no one is supposed to be using those older versions anymore and the EOL just happened very recently. That's the only reason I wanted to double-check: maybe something happened between the time you wrote the guidance, and I reviewed it! 😄

No reason not to get this live in docs then, although I do suspect at some point that issue will no longer be the case and we'll need to remove that. I'm sure someone will tell us when it happens. 😅

@sarah11918 sarah11918 merged commit aac5f1a into withastro:main Oct 22, 2023
yanthomasdev added a commit that referenced this pull request Nov 13, 2023
* i18n(fr) Update microsoft-azure.mdx

Update with #5057

* Update src/content/docs/fr/guides/deploy/microsoft-azure.mdx

Impeccable merci

Co-authored-by: Paul Valladares <[email protected]>

---------

Co-authored-by: Paul Valladares <[email protected]>
Co-authored-by: Yan Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. help wanted Issues looking for someone to run with them! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Issue with Azure Deployment Instructions
3 participants