Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Issue with Azure Deployment Instructions #4891

Closed
blueboxes opened this issue Sep 30, 2023 · 5 comments · Fixed by #5057
Closed

⚠️ Issue with Azure Deployment Instructions #4891

blueboxes opened this issue Sep 30, 2023 · 5 comments · Fixed by #5057
Labels
help wanted Issues looking for someone to run with them!

Comments

@blueboxes
Copy link
Contributor

On https://docs.astro.build/en/guides/deploy/microsoft-azure/

You must also set the engine in your packages.json as the static website build defaults to node 16 which is not compatible with astro

  "engines": {
    "node": ">=18.0.0"
  },

https://edi.wang/post/2022/1/27/how-to-specify-nodejs-version-when-building-azure-static-web-app

@blueboxes blueboxes changed the title ⚠️ Issue ⚠️ Issue with Azure Deployment Instructions Sep 30, 2023
@VoxelMC
Copy link
Contributor

VoxelMC commented Oct 6, 2023

@sarah11918 I was thinking about trying out the Azure deployment method, could you assign this to me and I can test it out while I'm at it?

@blueboxes
Copy link
Contributor Author

I have a few other bits I found that may improve the docs as well.

I plan to write a blog post, once done I will share here. I would be happy for any of the points to be incorporated into the official docs.

@blueboxes
Copy link
Contributor Author

Here is my post feel free to use as much of it as you wish.

https://www.blueboxes.co.uk/deploying-an-astro-website-to-azure-static-web-apps

I ran through both using vscode and the azure portal. The current astro guide in this GitHub issue covers everything except the need to set the engine in the package.json though in some places could be a bit clearer.

@TheOtterlord TheOtterlord added the help wanted Issues looking for someone to run with them! label Oct 11, 2023
@TheOtterlord
Copy link
Member

@VoxelMC we don't typically assign issues to people, but if an issue is open, that's your sign it's free to take! I've tagged this with help-wanted so people know it's available. If you're interested in making a PR, we'd love that!

@TheOtterlord
Copy link
Member

@blueboxes this looks really useful! We have a community resource section at the end of some CMS guides (example), and I think this would be a good opportunity to add one to our Azure deploy guide. We'd be open to a PR if you want to add your guide! Along with anything other feedback you might have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues looking for someone to run with them!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants