-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redistribute Built-in components and remove page #9888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
…guide material reorganized
github-actions
bot
added
the
i18n
Anything to do with internationalization & translation efforts - ask @YanThomas for help!
label
Oct 30, 2024
This was referenced Nov 6, 2024
This was referenced Nov 6, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Nov 6, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Nov 6, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Nov 6, 2024
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <[email protected]>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <[email protected]>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <[email protected]>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <[email protected]>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
* i18n(fr): Update `guides/troubleshooting.mdx` from #9888 Signed-off-by: Thomas Bonnet <[email protected]> * Blank line Co-authored-by: Armand Philippot <[email protected]> --------- Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: Armand Philippot <[email protected]> Co-authored-by: Yan <[email protected]>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: Yan <[email protected]>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
…n-reference.mdx` (#9934) * i18n(fr): add `guides/syntax-highlighting.mdx` See #9888 * i18n(fr): update `configuration-reference.mdx` See #9888 * i18n(fr): update a link in `integrations-guide/markdoc.mdx` --------- Co-authored-by: Yan <[email protected]> Co-authored-by: thomasbnt <[email protected]>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
* i18n(fr): Update `guides/markdown-content.mdx` from #9888 Signed-off-by: Thomas Bonnet <[email protected]> * blank line Co-authored-by: Armand Philippot <[email protected]> * blank lines Co-authored-by: Armand Philippot <[email protected]> * space before colon and last comment line was not translated Co-authored-by: Armand Philippot <[email protected]> * i18n(fr): Update `guides/v1.mdx` from #9888 Signed-off-by: Thomas Bonnet <[email protected]> --------- Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: Armand Philippot <[email protected]> Co-authored-by: Yan <[email protected]>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
See #9900 and #9888 Co-authored-by: Yan <[email protected]> Co-authored-by: thomasbnt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add new content
Document something that is not in docs. May require testing, confirmation, or affect other pages.
i18n
Anything to do with internationalization & translation efforts - ask @YanThomas for help!
information architecture
reorganizes content on the site
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR removes the Built-in Components reference page entirely in favour of redistributing the components to appropriate pages in docs.
(These components were not very similar to each other, did not all require imports, and in some cases were duplicate content existing in guides already.)
In the process:
markdown.shikiConfig
content to configuration reference rather than having that entry link to the Markdown guide (in-branch overwrite right now, until we know what we want at the source)Note: If we don't like the experiment of syntax highlighting as its own guide, this content can go back to the Markdown guide page. However, we would need to decide on a better place for the two Code and Prism components
UPDATE: The experimental changes above were well received on Talking and Doc'ing, so going with this overall structure for now!
i18n/nav
pages that had itFollow up: