Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(de): update astro-syntax.mdx #9942

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Conversation

trueberryless
Copy link
Contributor

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8ed6b4e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6730904ac7c2c8000829290a
😎 Deploy Preview https://deploy-preview-9942--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 7, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de basics/astro-syntax.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@jsparkdev
Copy link
Contributor

I found a few things that were wrong.

brave_screenshot_github com (1)

{item} and visiable are words that don't exist, but want to highlight them. This causes the highlighting to not render. (lines 80, 93)

@jsparkdev
Copy link
Contributor

In the original English, client:* hydration directives is set as a link, but here, only client:* is set as a link.

This seems wrong to me, but I could be wrong, as different countries have different language usage.

If this is what you intended, please let me know!

brave_screenshot_deploy-preview-9942--astro-docs-2 netlify app

@jsparkdev
Copy link
Contributor

Other than the parts mentioned above, everything else seems to be perfect!

@trueberryless
Copy link
Contributor Author

Thank you so much for not only looking at the new content, but the whole page! Otherwise, I would never have found those mistakes!

You are right with the client: * link, the other word was not highlighted...

@jsparkdev
Copy link
Contributor

LGTM!

@jsparkdev jsparkdev merged commit 3073502 into withastro:main Nov 10, 2024
10 checks passed
@trueberryless
Copy link
Contributor Author

Another cool tip, now that you're one of the maintainers:

You probably have seen many reviews from other people with over 1000 commits in 3 withastro repos, but I don't know if you know how to create a review. Follow this nice guide: 😉

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#starting-a-review

I'm just mentioning this because you posted the review as normal comments, so maybe I can help... 😊

@trueberryless
Copy link
Contributor Author

trueberryless commented Nov 10, 2024

Follow this nice guide: 😉

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#starting-a-review

One important point, I always miss when starting a review myself: Click the "Start a review" button (Step 10 in the GitHub guide). It's usually green and somewhere at the bottom right of the "files changed" page. 😉

@jsparkdev
Copy link
Contributor

@trueberryless Thanks!

By the way, it looks like I can only add reviews to modified code in PR, so I added this review as a general comment!

I often forget to hit the green button to complete a review, haha.

@trueberryless
Copy link
Contributor Author

By the way, it looks like I can only add reviews to modified code in PR, so I added this review as a general comment!

Oh yeah, I didn't think about this... Sorry 😔
What HiDeoo does in this situation though, is just to add the comment at the last possible line and mention something like "can't add comment there cause out of review range"

@jsparkdev
Copy link
Contributor

Thanks for the tip, I'll try it next time :)

@trueberryless trueberryless deleted the patch-2 branch November 10, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants