-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(de): update astro-syntax.mdx
#9942
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Other than the parts mentioned above, everything else seems to be perfect! |
Thank you so much for not only looking at the new content, but the whole page! Otherwise, I would never have found those mistakes! You are right with the |
LGTM! |
Another cool tip, now that you're one of the maintainers: You probably have seen many reviews from other people with over 1000 commits in 3 withastro repos, but I don't know if you know how to create a review. Follow this nice guide: 😉 I'm just mentioning this because you posted the review as normal comments, so maybe I can help... 😊 |
One important point, I always miss when starting a review myself: Click the "Start a review" button (Step 10 in the GitHub guide). It's usually green and somewhere at the bottom right of the "files changed" page. 😉 |
@trueberryless Thanks! By the way, it looks like I can only add reviews to modified code in PR, so I added this review as a general comment! I often forget to hit the green button to complete a review, haha. |
Oh yeah, I didn't think about this... Sorry 😔 |
Thanks for the tip, I'll try it next time :) |
Description (required)
astro-syntax.mdx
Related issues & labels (optional)