Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression parsing when final node #909

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

natemoo-re
Copy link
Member

Changes

  • Fixes a crash discovered in Upgrade compiler astro#9445
  • When an expression is the final node in a file, we need to check the access to p.oe.top() to ensure there is actually an open element.

Testing

Test added

Docs

Bug fix only

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: 382e835

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re natemoo-re merged commit 56e1959 into main Dec 15, 2023
5 checks passed
@natemoo-re natemoo-re deleted the fix/trailing-expression branch December 15, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant