Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade compiler #9445

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Upgrade compiler #9445

merged 2 commits into from
Dec 15, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Dec 15, 2023

Changes

  • Upgrades @astrojs/compiler to ^2.3.4.
  • In practice, this fixes an issue where multibyte characters would cause the sourcemapper to crash
  • A few other index out of range issues were fixed as well!
  • Also fixed a fun new bug that this test suite uncovered related to expressions being the final node in a file

Testing

CI

Docs

Bug fix only

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: d6e755a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 15, 2023
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some test failures.

@natemoo-re natemoo-re merged commit f963d07 into main Dec 15, 2023
13 checks passed
@natemoo-re natemoo-re deleted the feat/upgrade-compiler branch December 15, 2023 20:53
@astrobot-houston astrobot-houston mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants