feat(astro): improve astro:content types
#9906
Merged
+84
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02e47d0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
…florian-lefebvre/astro into feat/content-types-improvements
ematipico
approved these changes
Jan 31, 2024
natemoo-re
approved these changes
Jan 31, 2024
|
Yeah it was on my todo but I was a bit scared of it ngl! Hopefully arsh was here to save me on the weird TS bits 🙌 |
natemoo-re
reviewed
Jan 31, 2024
natemoo-re
approved these changes
Feb 5, 2024
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, the
astro:contentmodule is not typed beforeastro syncis run, although exporteddefineCollectionandzdo not depend on codegen. This PR moves them from types template to a "static" virtual module type declaration.Testing
Manually in the
blogexample. Tests should still pass.Docs
I think parts of the docs will need to be updated, I'm thinking about the tutorial. Basically reverting this https://github.com/withastro/docs/pull/6272/files#diff-ec9625e9b89360bd7a29d0d392017cbb704e8890a12534044ca2374dddb9fdb5R181