Move astro:content types declaration to manual ambient module
#10013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7fa02e6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
florian-lefebvre
approved these changes
Feb 7, 2024
Princesseuh
approved these changes
Feb 7, 2024
bluwy
approved these changes
Feb 7, 2024
ematipico
approved these changes
Feb 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro:contenttypes #9906astro:contenttypes #9906 seemed equivalent (or even identical 😁) to the content collection types previously generated byastro sync, it seems some subtleties in the difference between a regular.d.tsand an ambientdeclare module {}impacted users..d.tsfile which is included via a triple-slash reference inclient.d.ts.Testing
Tested manually in a Starlight project that was failing
Docs
n/a — bug fix only with no visible change to users