Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tsconfck instead of tsconfig-resolver #8798

Merged
merged 10 commits into from
Oct 11, 2023
Merged

Conversation

Princesseuh
Copy link
Member

Changes

tsconfig-resolver is unmaintained and doesn't support all of newer TypeScript's features. tsconfck is also in use by many reputable project and should be a safer dep to have.

Fix #6918

Testing

Tests should pass!

Docs

N/A

@Princesseuh Princesseuh requested a review from a team as a code owner October 10, 2023 16:53
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: fad5457

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 10, 2023
@Princesseuh Princesseuh marked this pull request as draft October 10, 2023 17:04
@Princesseuh Princesseuh marked this pull request as ready for review October 11, 2023 09:17
packages/astro/src/cli/add/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for pinning the exact pre-release version. We'll need to remember to keep an eye on that when it gets bumped to latest.

@Princesseuh Princesseuh merged commit f369fa2 into main Oct 11, 2023
3 checks passed
@Princesseuh Princesseuh deleted the feat/tsconfck branch October 11, 2023 16:01
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Oct 11, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@astrobot-houston astrobot-houston mentioned this pull request Oct 11, 2023
@firxworx
Copy link

Looks good this is a nice contribution @Princesseuh :)
If the motivation is to support ts5 extends format / multiple extends do you think there should be a test / fixture that covers that case? Maybe I missed when I skimmed down files changed but I didn't catch. Thanks again!

@Princesseuh
Copy link
Member Author

Looks good this is a nice contribution @Princesseuh :)
If the motivation is to support ts5 extends format / multiple extends do you think there should be a test / fixture that covers that case? Maybe I missed when I skimmed down files changed but I didn't catch. Thanks again!

We could for sure, but we'd rather avoid testing every feature like this that are ultimately outside of our code. We trust tsconfck to do what it says, especially considering it's used upstream from us (Vite uses it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to support TS 5.0 tsconfig extends array
4 participants