-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use tsconfck instead of tsconfig-resolver #8798
Conversation
🦋 Changeset detectedLatest commit: fad5457 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for pinning the exact pre-release version. We'll need to remember to keep an eye on that when it gets bumped to latest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
Looks good this is a nice contribution @Princesseuh :) |
We could for sure, but we'd rather avoid testing every feature like this that are ultimately outside of our code. We trust |
Changes
tsconfig-resolver
is unmaintained and doesn't support all of newer TypeScript's features.tsconfck
is also in use by many reputable project and should be a safer dep to have.Fix #6918
Testing
Tests should pass!
Docs
N/A